Conversation
sagar-qa007
requested review from
ApekshaBhosale and
sharat87
as code owners
WalkthroughThis PR updates multiple CI workflows and Cypress scripts. The workflows now set a new environment variable ( Changes
Sequence Diagram(s)sequenceDiagram
participant Trigger as Workflow Trigger
participant CI as CI Workflow
participant Cypress as Cypress Test Runner
Trigger->>CI: Start Workflow
CI->>CI: Set GITHUB_WORKFLOW from github.workflow
CI->>CI: Check for inputs.spec & run_count
alt inputs.spec provided
CI->>Cypress: Execute Cypress with '--spec' flag
else
CI->>Cypress: Execute Cypress normally
end
alt run_count defined
loop run_count times
CI->>Cypress: Repeat test execution
end
end
Cypress-->>CI: Return test results
sequenceDiagram
participant App as App Client
participant Util as Utility Module
participant DB as Database
App->>Util: getVars()
Util-->>App: Returns vars including gitWorkflowName
App->>DB: Insert commitMsg with appended workflow name
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/ci-test-hosted.yml (1)
251-251: Fix YAML formatting.There are too many spaces before the colon in the
GITHUB_WORKFLOWenvironment variable definition.Apply this diff to fix the formatting:
- GITHUB_WORKFLOW : ${{ github.workflow }} + GITHUB_WORKFLOW: ${{ github.workflow }}🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 251-251: too many spaces before colon
(colons)
.github/workflows/ci-test-limited.yml (1)
345-345: Fix YAML formatting.Remove extra spaces before the colon to maintain consistent YAML formatting.
- GITHUB_WORKFLOW : ${{ github.workflow }} + GITHUB_WORKFLOW: ${{ github.workflow }}🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 345-345: too many spaces before colon
(colons)
.github/workflows/ci-test-custom-script.yml (1)
374-374: Fix YAML formatting.Remove extra spaces before the colon to maintain consistent YAML formatting.
- GITHUB_WORKFLOW : ${{ github.workflow }} + GITHUB_WORKFLOW: ${{ github.workflow }}.github/workflows/ci-test-limited-with-count.yml (1)
430-430: Fix YAML formatting.Remove extra spaces before the colon to maintain consistent YAML formatting.
- GITHUB_WORKFLOW : ${{ github.workflow }} + GITHUB_WORKFLOW: ${{ github.workflow }}🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 430-430: too many spaces before colon
(colons)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/workflows/ci-test-custom-script.yml(1 hunks).github/workflows/ci-test-hosted.yml(1 hunks).github/workflows/ci-test-limited-with-count.yml(1 hunks).github/workflows/ci-test-limited.yml(1 hunks)app/client/cypress/scripts/cypress-split-dynamic.ts(2 hunks)app/client/cypress/scripts/cypress-split-static.ts(2 hunks)app/client/cypress/scripts/util.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`app/client/cypress/**/**.*`: Review the following e2e test ...
app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/scripts/cypress-split-dynamic.tsapp/client/cypress/scripts/cypress-split-static.tsapp/client/cypress/scripts/util.ts
🪛 YAMLlint (1.35.1)
.github/workflows/ci-test-hosted.yml
[warning] 251-251: too many spaces before colon
(colons)
.github/workflows/ci-test-limited-with-count.yml
[warning] 430-430: too many spaces before colon
(colons)
.github/workflows/ci-test-limited.yml
[warning] 345-345: too many spaces before colon
(colons)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: perform-test / client-build / client-build
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: perform-test / rts-build / build
- GitHub Check: client-lint / client-lint
- GitHub Check: client-build / client-build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (4)
app/client/cypress/scripts/util.ts (1)
45-45: LGTM!The addition of
gitWorkflowNamefollows the existing pattern for environment variable retrieval and is correctly marked as non-required.app/client/cypress/scripts/cypress-split-static.ts (1)
70-71: LGTM!The addition of workflow name to commit message helps differentiate between Release and Airgap workflows in the database.
Also applies to: 83-83
app/client/cypress/scripts/cypress-split-dynamic.ts (1)
101-102: LGTM!The changes mirror those in cypress-split-static.ts, maintaining consistency across both split strategies.
Also applies to: 114-114
.github/workflows/ci-test-limited-with-count.yml (1)
17-21: LGTM! Good addition of the run_count parameter.The new parameter allows for flexible test execution by specifying the number of test runs, with a sensible default of 1.
btsgh
left a comment
btsgh
left a comment
There was a problem hiding this comment.
For identifying airgapped specific workflows.
## Description **Problem**: The Schedule TBP data for both Release and Airgap workflows is currently identical in the database, making it difficult to distinguish between them. **Solution**: Added the workflow name to the commitMsg column, ensuring a clear and accurate view of the data for each workflow. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39253 ## Automation /ok-to-test tags="@tag.SignIn" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13309520198> > Commit: 87d33db > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13309520198&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.SignIn` > Spec: > <hr>Thu, 13 Feb 2025 14:28:44 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a customizable input to specify the number of test iterations. - Updated test commands to conditionally target specific test files based on provided parameters. - **Tests** - Enhanced test reporting by appending workflow context to commit messages. - Improved workflow tracking with the addition of a variable reflecting the active workflow name. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
Description
Problem: The Schedule TBP data for both Release and Airgap workflows is currently identical in the database, making it difficult to distinguish between them.
Solution: Added the workflow name to the commitMsg column, ensuring a clear and accurate view of the data for each workflow.
Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39253
Automation
/ok-to-test tags="@tag.SignIn"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13309520198
Commit: 87d33db
Cypress dashboard.
Tags:
@tag.SignInSpec:
Thu, 13 Feb 2025 14:28:44 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Tests