chore: fixing discard message

[brayn003]

Description

Discard toast issue, introduced in #39140

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13240898404
Commit: f8e760a
Cypress dashboard.
Tags: @tag.Git
Spec:
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts

List of identified flaky tests.

---

Mon, 10 Feb 2025 22:21:53 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes
  • Updated the discard confirmation so users now receive a clear success notification, ensuring more accurate feedback when changes are discarded.

[coderabbitai]

Walkthrough

This pull request updates the discard operation in TabDeployView.tsx by introducing a new constant, DISCARD_SUCCESS. The modification changes the call in the triggerDiscardChanges function from using DISCARD_CHANGES to DISCARD_SUCCESS, affecting the message passed during the discard process while keeping the overall logic unchanged.

Changes

File	Change Summary
app/client/src/.../TabDeployView.tsx	Added a new constant DISCARD_SUCCESS and updated the triggerDiscardChanges function accordingly.

Sequence Diagram(s)

(No sequence diagrams generated as the changes do not alter control flow.)

Possibly related PRs

• chore: git mod - fixes toast issues #39140: Addresses modifications in the discard function's invocation and message handling which align with the changes implemented in this PR.

Suggested labels

Bug, ok-to-test, Git Product, skip-changelog

Suggested reviewers

• ashit-rath
• NandanAnantharamu

Poem

In the realm of code so grand,
A change was made, subtle and planned.
Success now guides the discard's call,
A tiny tweak, yet valued by all.
Cheers to progress in every command!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa6ee5e and f8e760a.

📒 Files selected for processing (1)

• app/client/src/git/components/OpsModal/TabDeploy/TabDeployView.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-build / client-build
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies

🔇 Additional comments (2)

app/client/src/git/components/OpsModal/TabDeploy/TabDeployView.tsx (2)

14-16: LGTM! Import addition maintains order.

The new DISCARD_SUCCESS constant is correctly imported and maintains alphabetical order.

---

239-247: Verify toast message behavior.

The change from DISCARD_CHANGES to DISCARD_SUCCESS aligns with the PR objective to fix the discard toast message. However, let's verify that this constant exists and contains the correct message.

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify the DISCARD_SUCCESS constant exists and contains the correct message
# Search for the constant definition
rg -A 1 "DISCARD_SUCCESS.*=" app/client/src/

Length of output: 279

---

Toast Message Verified

• The constant DISCARD_SUCCESS is defined in app/client/src/ce/constants/messages.ts and returns the expected message "Discarded changes successfully."
• The code in TabDeployView.tsx correctly uses createMessage(DISCARD_SUCCESS) to show the updated toast message.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[brayn003]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13240895207.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 39155.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-39155.dp.appsmith.com