Skip to content

Updated test-build-docker-image.yml to retry master TBPs #39151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yatinappsmith merged 1 commit into from
Feb 10, 2025
Merged

Updated test-build-docker-image.yml to retry master TBPs #39151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-build-docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ jobs:

# This step triggers an external workflow for automated analysis of Cypress test runs.
- name: Invoke Automated analysis workflow
if: ( always() && github.ref == 'refs/heads/release' && github.run_attempt <= 2)
if: (always() && (github.ref == ‘refs/heads/release’ || github.ref == ‘refs/heads/master’) && github.run_attempt <= 2)
run: |
Comment on lines +243 to 244
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix Quotation Mark Issues in Conditional Expression

The condition on line 243 uses typographic single quotes (‘ and ’) rather than standard ASCII single quotes ('). This causes a lexing error during workflow execution. Please update the quotes to standard single quotes to ensure the YAML is parsed correctly.

-        if: (always() && (github.ref == ‘refs/heads/release’ || github.ref == ‘refs/heads/master’) && github.run_attempt <= 2)
+        if: (always() && (github.ref == 'refs/heads/release' || github.ref == 'refs/heads/master') && github.run_attempt <= 2)

[refactor_suggestion_essential]

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if: (always() && (github.ref == ‘refs/heads/release’ || github.ref == ‘refs/heads/master’) && github.run_attempt <= 2)
run: |
if: (always() && (github.ref == 'refs/heads/release' || github.ref == 'refs/heads/master') && github.run_attempt <= 2)
run: |
🧰 Tools
🪛 actionlint (1.7.4)

243-243: got unexpected character '‘' while lexing expression, expecting 'a'..'z', 'A'..'Z', '_', '0'..'9', ''', '}', '(', ')', '[', ']', '.', '!', '<', '>', '=', '&', '|', '*', ',', ' '

(expression)

curl --location --request POST ${{secrets.CYPRESS_WORKFLOW_API}} \
--header 'x-appsmith-key: ${{ secrets.CYPRESS_WORKFLOW_KEY }}' \
Expand Down