Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ interface TabDeployViewProps {
commit: (commitMessage: string) => void;
commitError: GitApiError | null;
currentBranch: string | null;
discard: () => void;
discard: (successMessage: string) => void;
discardError: GitApiError | null;
isCommitLoading: boolean;
isDiscardLoading: boolean;
Expand Down Expand Up @@ -239,7 +239,7 @@ function TabDeployView({
AnalyticsUtil.logEvent("GIT_DISCARD", {
source: "GIT_DISCARD_BUTTON_PRESS_2",
});
discard();
discard(createMessage(DISCARD_CHANGES));
setShowDiscardWarning(false);
setShouldDiscard(true);
setIsDiscarding(true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
AUTOCOMMIT_IN_PROGRESS_MESSAGE,
COMMIT_CHANGES,
createMessage,
DISCARD_AND_PULL_SUCCESS,
GIT_SETTINGS,
MERGE,
} from "ee/constants/messages";
Expand All @@ -27,7 +28,7 @@ const Container = styled.div`

interface QuickActionsViewProps {
currentBranch: string | null;
discard: () => void;
discard: (successMessage: string) => void;
isAutocommitEnabled: boolean;
isAutocommitPolling: boolean;
isBranchPopupOpen: boolean;
Expand Down Expand Up @@ -105,7 +106,7 @@ function QuickActionsView({
});

if (isProtectedMode) {
discard();
discard(createMessage(DISCARD_AND_PULL_SUCCESS));
} else {
pull();
}
Expand Down
19 changes: 14 additions & 5 deletions app/client/src/git/hooks/useDiscard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,20 @@ export default function useDiscard() {

const discardState = useArtifactSelector(selectDiscardState);

const discard = useCallback(() => {
if (artifactDef && artifactId) {
dispatch(gitArtifactActions.discardInit({ artifactDef, artifactId }));
}
}, [artifactDef, artifactId, dispatch]);
const discard = useCallback(
(successMessage: string) => {
if (artifactDef && artifactId) {
dispatch(
gitArtifactActions.discardInit({
artifactDef,
artifactId,
successMessage,
}),
);
}
},
[artifactDef, artifactId, dispatch],
);

const clearDiscardError = useCallback(() => {
if (artifactDef) {
Expand Down
11 changes: 6 additions & 5 deletions app/client/src/git/sagas/discardSaga.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { toast } from "@appsmith/ads";
import { captureException } from "@sentry/react";
import { builderURL } from "ee/RouteBuilder";
import { createMessage, DISCARD_SUCCESS } from "ee/constants/messages";
import discardRequest from "git/requests/discardRequest";
import type { DiscardResponse } from "git/requests/discardRequest.types";
import type { DiscardInitPayload } from "git/store/actions/discardActions";
Expand All @@ -15,7 +14,7 @@ import { validateResponse } from "sagas/ErrorSagas";
export default function* discardSaga(
action: GitArtifactPayloadAction<DiscardInitPayload>,
) {
const { artifactDef, artifactId } = action.payload;
const { artifactDef, artifactId, successMessage } = action.payload;

let response: DiscardResponse | undefined;

Expand All @@ -34,9 +33,11 @@ export default function* discardSaga(

if (response && isValidResponse) {
yield put(gitArtifactActions.discardSuccess({ artifactDef }));
toast.show(createMessage(DISCARD_SUCCESS), {
kind: "success",
});

if (successMessage) {
toast.show(successMessage, { kind: "success" });
}

// adding delay to show toast animation before reloading
yield delay(500);
const basePageId: string =
Expand Down
6 changes: 6 additions & 0 deletions app/client/src/git/sagas/pullSaga.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import { APP_MODE } from "entities/App";
import log from "loglevel";
import { captureException } from "@sentry/react";
import { selectGitApiContractsEnabled } from "git/store/selectors/gitFeatureFlagSelectors";
import { toast } from "@appsmith/ads";
import { createMessage, DISCARD_AND_PULL_SUCCESS } from "ee/constants/messages";

export default function* pullSaga(
action: GitArtifactPayloadAction<PullInitPayload>,
Expand Down Expand Up @@ -50,6 +52,10 @@ export default function* pullSaga(
mode: APP_MODE.EDIT,
}),
);

toast.show(createMessage(DISCARD_AND_PULL_SUCCESS), {
kind: "success",
});
}
} catch (e) {
if (response && response.responseMeta.error) {
Expand Down
6 changes: 6 additions & 0 deletions app/client/src/git/sagas/updateProtectedBranchesSaga.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { toast } from "@appsmith/ads";
import { captureException } from "@sentry/react";
import { createMessage, PROTECT_BRANCH_SUCCESS } from "ee/constants/messages";
import updateProtectedBranchesRequest from "git/requests/updateProtectedBranchesRequest";
import type {
UpdateProtectedBranchesRequestParams,
Expand Down Expand Up @@ -41,6 +43,10 @@ export default function* updateProtectedBranchesSaga(
gitArtifactActions.updateProtectedBranchesSuccess({ artifactDef }),
);
yield put(gitArtifactActions.fetchProtectedBranchesInit({ artifactDef }));

toast.show(createMessage(PROTECT_BRANCH_SUCCESS), {
kind: "success",
});
}
} catch (e) {
if (response && response.responseMeta.error) {
Expand Down
1 change: 1 addition & 0 deletions app/client/src/git/store/actions/discardActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type {

export interface DiscardInitPayload extends GitArtifactBasePayload {
artifactId: string;
successMessage?: string;
}

export const discardInitAction = createArtifactAction<DiscardInitPayload>(
Expand Down
Loading