Skip to content

ci: Update version and checking failure #39138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sagar-qa007 merged 17 commits into from
Feb 13, 2025
+40 −41
Merged

ci: Update version and checking failure #39138

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
013d842
Update version and checking failure
sagar-qa007 Feb 7, 2025
d869509
Update new version
sagar-qa007 Feb 9, 2025
a5be284
updated version to 4
sagar-qa007 Feb 9, 2025
ed57144
Update to 5
sagar-qa007 Feb 10, 2025
b66dc3d
Merge branch 'release' into ci/updatecypressrepeate
sagar-qa007 Feb 10, 2025
9bab61a
update
sagar-qa007 Feb 10, 2025
ea8d979
update
sagar-qa007 Feb 10, 2025
7fad12c
version 6
sagar-qa007 Feb 11, 2025
7e38635
pr autmation
sagar-qa007 Feb 11, 2025
14cc681
reverted the changes
sagar-qa007 Feb 11, 2025
a5c7c8a
Updated to version 7
sagar-qa007 Feb 11, 2025
8e306ab
update to version 8
sagar-qa007 Feb 11, 2025
b8414d9
Merge branch 'release' into ci/updatecypressrepeate
sagar-qa007 Feb 12, 2025
f141c7a
update to version 9
sagar-qa007 Feb 12, 2025
0408776
reverted test
sagar-qa007 Feb 12, 2025
609031b
ci test limit update
sagar-qa007 Feb 12, 2025
9c4fb37
update limited-count flow
sagar-qa007 Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .github/workflows/ci-test-custom-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ jobs:
fi

- name: Run the cypress test
uses: cypress-io/github-action@v6
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CYPRESS_USERNAME: ${{ secrets.CYPRESS_USERNAME }}
Expand Down Expand Up @@ -371,13 +370,21 @@ jobs:
CYPRESS_SNOWFLAKE_ACCOUNT_NAME: ${{ secrets.SNOWFLAKE_ACCOUNT_NAME }}
CYPRESS_SNOWFLAKE_USERNAME: ${{ secrets.SNOWFLAKE_USERNAME }}
CYPRESS_SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
with:
browser: ${{ env.BROWSER_PATH }}
install: false
config-file: cypress_ci_custom.config.ts
spec: ${{ inputs.spec }}
working-directory: app/client
env: "NODE_ENV=development"
NODE_ENV: development
run: |
cd app/client
ls -la
if [[ -n "${{ inputs.spec }}" ]]; then
npx cypress-repeat-pro run -n 3 --rerun-failed-only \
--spec "${{ inputs.spec }}" \
--config-file "cypress_ci_custom.config.ts" \
--browser "${{ env.BROWSER_PATH }}"
else
npx cypress-repeat-pro run -n 3 --rerun-failed-only \
--config-file "cypress_ci_custom.config.ts" \
--browser "${{ env.BROWSER_PATH }}"
fi
cat cy-repeat-summary.txt
Comment thread
sagar-qa007 marked this conversation as resolved.

- name: Trim number of cypress log files
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion app/client/cypress/e2e/Regression/ClientSide/Homepage/HomepageExperienceV2_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import HomepageLocators from "../../../../locators/HomePage";

describe(
"Validate Homepage Experience V2 changes",
{ tags: ["@tag.Workspace", "@tag.AccessControl"] },
{ tags: ["@tag.Workspace", "@tag.AccessControl", "@tag.SignIn"] },
function () {
before(() => {});

Expand All @@ -27,6 +27,7 @@ describe(
});

it("2. Entity Search bar should be visible on Homepage and not visible on Settings and Editor", () => {
expect(false).to.be.true;

@coderabbitai coderabbitai Bot Feb 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove the intentionally failing assertion.

The assertion expect(false).to.be.true will always fail and breaks the test suite.

-      expect(false).to.be.true;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
expect(false).to.be.true;
// (Line removed from the test file)

homePage.CreateNewApplication();
agHelper.AssertElementAbsence(HomepageLocators._entitySearchBar);
homePage.NavigateToHome();
Expand Down
4 changes: 2 additions & 2 deletions app/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
"craco-alias": "^2.1.1",
"craco-babel-loader": "^1.0.4",
"cypress-log-to-output": "^1.1.2",
"cypress-repeat-pro": "^1.0.1",
"cypress-repeat-pro": "^1.0.6",
"d3-geo": "^3.1.0",
"date-fns": "^4.1.0",
"dayjs": "^1.10.6",
Expand Down Expand Up @@ -388,4 +388,4 @@
"@types/react": "^17.0.2",
"postcss": "8.4.31"
}
}
}
33 changes: 11 additions & 22 deletions app/client/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13272,7 +13272,7 @@ __metadata:
cypress-network-idle: ^1.14.2
cypress-plugin-tab: ^1.0.5
cypress-real-events: ^1.8.1
cypress-repeat-pro: ^1.0.1
cypress-repeat-pro: ^1.0.6
cypress-tags: ^1.1.2
cypress-terminal-report: ^5.3.6
cypress-wait-until: ^1.7.2
Expand Down Expand Up @@ -16571,19 +16571,20 @@ __metadata:
languageName: node
linkType: hard

"cypress-repeat-pro@npm:^1.0.1":
version: 1.0.1
resolution: "cypress-repeat-pro@npm:1.0.1"
"cypress-repeat-pro@npm:^1.0.6":
version: 1.0.6
resolution: "cypress-repeat-pro@npm:1.0.6"
dependencies:
"@cypress/grep": ^4.0.1
arg: 5.0.2
bluebird: 3.7.2
debug: 4.3.5
debug: ^4.4.0
dotenv: 8.2.0
peerDependencies:
cypress: ">=5.3.0"
bin:
cypress-repeat-pro: index.js
checksum: e62a21479b62a5d5624ce21bdd8204afd754082d851d5fc712ad76e39ca2cfe6d446c2a1434025be77fa9d76fa257609285879e9841efecc26be4d25454fb732
checksum: 4207a798e6e70fde3cb55d0cf8944bd76817a940ae817d61b72e3624daf0d26212cda05c70a6b2e0caf137ad06df4623d3869a2288de4568cd4a1f58b2b77b81
languageName: node
linkType: hard

Expand Down Expand Up @@ -16790,15 +16791,15 @@ __metadata:
languageName: node
linkType: hard

"debug@npm:4, debug@npm:^4.0.0, debug@npm:^4.1.0, debug@npm:^4.1.1, debug@npm:^4.3.0, debug@npm:^4.3.1, debug@npm:^4.3.2, debug@npm:^4.3.3, debug@npm:^4.3.4":
version: 4.3.7
resolution: "debug@npm:4.3.7"
"debug@npm:4, debug@npm:^4.0.0, debug@npm:^4.1.0, debug@npm:^4.1.1, debug@npm:^4.3.0, debug@npm:^4.3.1, debug@npm:^4.3.2, debug@npm:^4.3.3, debug@npm:^4.3.4, debug@npm:^4.4.0":
version: 4.4.0
resolution: "debug@npm:4.4.0"
dependencies:
ms: ^2.1.3
peerDependenciesMeta:
supports-color:
optional: true
checksum: 822d74e209cd910ef0802d261b150314bbcf36c582ccdbb3e70f0894823c17e49a50d3e66d96b633524263975ca16b6a833f3e3b7e030c157169a5fabac63160
checksum: fb42df878dd0e22816fc56e1fdca9da73caa85212fbe40c868b1295a6878f9101ae684f4eeef516c13acfc700f5ea07f1136954f43d4cd2d477a811144136479
languageName: node
linkType: hard

Expand All @@ -16814,18 +16815,6 @@ __metadata:
languageName: node
linkType: hard

"debug@npm:4.3.5":
version: 4.3.5
resolution: "debug@npm:4.3.5"
dependencies:
ms: 2.1.2
peerDependenciesMeta:
supports-color:
optional: true
checksum: 7c002b51e256257f936dda09eb37167df952758c57badf6bf44bdc40b89a4bcb8e5a0a2e4c7b53f97c69e2970dd5272d33a757378a12c8f8e64ea7bf99e8e86e
languageName: node
linkType: hard

"debug@npm:^3.1.0, debug@npm:^3.2.7":
version: 3.2.7
resolution: "debug@npm:3.2.7"
Expand Down