-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: Activating the feature flag in cypress for using Entity Item component from ADS templates #39093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: Activating the feature flag in cypress for using Entity Item component from ADS templates #39093
Changes from 73 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
1682ff2
removing feature flag for using new Entity Item component from ADS te…
ankitakinger 75b36b7
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 304b6d7
fixing failing unit tests
ankitakinger e068b56
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger edbba40
fixing another unit test
ankitakinger 5c13d0e
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 345fd93
updating locators
ankitakinger a5b55a1
fixing unit tests
ankitakinger a4551fa
updating selected entity item selector
ankitakinger e320299
fixing some more tests
ankitakinger 672e056
fixing some more tests
ankitakinger bdc0de9
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 0182006
fixing a couple of integration tests
ankitakinger e864601
minor change
ankitakinger 500002f
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 675a44e
fixing more tests
ankitakinger dc62804
fix for failing tests
ankitakinger 29ad43c
fix for failing tests
ankitakinger f1452fb
reverting double click changes on entity item
ankitakinger 7e84052
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 521dc3e
updating a test
ankitakinger 73bfc57
fixing remaining tests
ankitakinger 76f393a
fixing another set of failing tests
ankitakinger 8acb96f
fixing client build
ankitakinger 78fbcc4
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 9bacf69
feat: Add useActiveDoubleClick hook for improved double-click handling
hetunandu 33461e2
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 69c15bc
chore: Improvements to useActiveDoubleClick
hetunandu 7aa10e2
Merge branch 'chore/entity-item-double-click' of https://github.com/a…
ankitakinger 2b591c2
Merge branch 'release' into chore/entity-item-double-click
hetunandu 239a945
Merge branch 'chore/entity-item-double-click' of https://github.com/a…
ankitakinger 4e1852e
fixing client build
ankitakinger 6d6a15a
fixing unit test
ankitakinger a4eefd0
fixing a few tests
ankitakinger 6c232ca
fixing a few tests
ankitakinger 0c51244
fixing some tests
ankitakinger 531a76d
fixing yet another test
ankitakinger 9473f99
and another
ankitakinger bfa6253
Merge branch 'release' into chore/remove-ff-entity-item-usage
hetunandu 3a8c91b
fix: build issue
hetunandu e299af4
Merge remote-tracking branch 'origin/release' into chore/remove-ff-en…
hetunandu d88dfd7
Merge branch 'chore/remove-ff-entity-item-usage' of github.com:/appsm…
hetunandu 13814dc
fix: Null check
hetunandu ea1bd3e
chore: Fix widget name fisasco adjustment
hetunandu b02398b
fix: Build issue with type change
hetunandu 5a90ebc
fix: DSL parent ids
hetunandu dc24d29
fix: Page Element hook usage
hetunandu 2d726be
Merge branch 'release' into chore/remove-ff-entity-item-usage
hetunandu 29711d5
Sync changes from EE excluding enterprise directory
hetunandu 69a3ddc
Merge branch 'release' into chore/remove-ff-entity-item-usage
hetunandu dabfa7d
Discard changes to app/client/src/ce/pages/AppIDE/components/JSListIt…
hetunandu e35c689
Discard changes to app/client/src/ce/pages/AppIDE/components/QueryEnt…
hetunandu b74ccf9
Discard changes to app/client/src/ee/pages/AppIDE/components/JSListIt…
hetunandu 0e996ab
Discard changes to app/client/src/ee/pages/AppIDE/components/QueryEnt…
hetunandu d9e3bad
Discard changes to app/client/src/pages/AppIDE/components/JSExplorer/…
hetunandu 6344db4
Discard changes to app/client/src/pages/AppIDE/components/PageList/Ol…
hetunandu 042daf7
Discard changes to app/client/src/pages/AppIDE/components/QueryEntity…
hetunandu 77f4b13
Discard changes to app/client/src/pages/AppIDE/components/QueryExplor…
hetunandu 627aafd
Discard changes to app/client/src/pages/AppIDE/components/UIEntityLis…
hetunandu 6eefeb4
Discard changes to app/client/src/pages/AppIDE/components/UIList/UILi…
hetunandu b39b620
Discard changes to app/client/src/pages/AppIDE/components/UIList/UILi…
hetunandu f086dc2
Discard changes to app/client/src/pages/Editor/Explorer/Widgets/OldWi…
hetunandu 88cb2f7
Discard changes to app/client/src/pages/Editor/Explorer/Widgets/Widge…
hetunandu 3ea586c
Discard changes to app/client/src/pages/Editor/Explorer/Widgets/Widge…
hetunandu eb9a9d2
chore: Revert few changes
hetunandu 8908314
Merge branch 'chore/remove-ff-entity-item-usage' of github.com:/appsm…
hetunandu 2435fd1
Discard changes to app/client/src/ce/entities/FeatureFlag.ts
hetunandu c19af30
enable feature flag in tests
hetunandu c1a36af
Revert "Discard changes to app/client/src/pages/AppIDE/components/UIL…
hetunandu 22d8d6b
Merge remote-tracking branch 'origin/release' into chore/remove-ff-en…
hetunandu 43e0b73
fix: some locators post new merge
hetunandu 94f0fc5
Merge remote-tracking branch 'origin/release' into chore/remove-ff-en…
hetunandu 0183f03
fix: Delete all queries in DB
hetunandu 68579f6
fix: PageActions_spec
hetunandu 08bb0b9
fix: Unit tests
hetunandu 8a4a200
Merge branch 'release' into chore/remove-ff-entity-item-usage
hetunandu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use structured assertions instead of plain strings.
Direct string assertions should be replaced with more structured expectations.
📝 Committable suggestion