Skip to content

chore: Move up the folder#39000

Closed
hetunandu wants to merge 2 commits intoreleasefrom
chore/app-ide-folder-structure
Closed

chore: Move up the folder#39000
hetunandu wants to merge 2 commits intoreleasefrom
chore/app-ide-folder-structure

Conversation

@hetunandu
Copy link
Member

@hetunandu hetunandu commented Feb 4, 2025

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Warning

Tests have not run on the HEAD 319c8bb yet


Tue, 04 Feb 2025 08:32:29 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor

    • Reorganized internal module structure and updated module paths across components.
    • Consolidated export statements for improved maintainability.
  • Chores

    • Adjusted test import paths and mocks to align with the new directory structure.
    • Removed outdated re-exports to streamline future development.

These changes are internal and do not affect the application’s visible functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request reorganizes the code structure by updating multiple import paths from the Editor/IDE directories to AppIDE directories. It adjusts imports for functions, components, hooks, and lazy-loaded modules across various areas such as navigation, query handling, JS utilities, headers, layouts, and tests. In addition, several module re-export statements have been introduced to centralize access to these functionalities, while outdated export statements and redundant files have been removed. Overall, the changes are structural in nature and do not affect the underlying logic or behavior of the code.

Changes

File(s) Change Summary
app/client/src/ce/navigation/FocusSetters.ts, app/client/src/ce/pages/AppIDE/EditorPane/JS/ListItem.tsx, app/client/src/ce/pages/AppIDE/EditorPane/JS/hooks.tsx, app/client/src/ce/pages/AppIDE/Query/ListItem.tsx, etc. Updated import paths from Editor/IDE to AppIDE for functions, components, hooks, lazy-loaded modules, and utilities.
app/client/src/ce/pages/AppIDE/EditorPane/JS/utils/getJSContextMenuByIdeType.tsx, app/client/src/ce/pages/AppIDE/Query/utils/getQueryContextMenuByIdeType.tsx, app/client/src/ce/pages/common/AppHeader.tsx, app/client/src/ce/selectors/appIDESelectors.ts Revised import sources for context menus, headers, and selector utilities to reflect the new directory structure.
Files under app/client/src/ee/pages/AppIDE/EditorPane/... and .../Query/... (e.g., ListItem.tsx, hooks.ts, utils files) Introduced module re-export statements to offer a centralized access point for components and utilities now residing in the AppIDE context.
Files under app/client/src/ee/pages/Editor/IDE/... (e.g., JS/ListItem.tsx, JS/hooks.ts, Query/ListItem.tsx, etc.) Removed export statements and deleted standalone files that served as redundant proxies, eliminating obsolete declarations.
Test files such as OnBoarding.test.tsx, AppsmithIDE.test.tsx, GlobalHotKeys.test.tsx, etc. Adjusted mock and component import paths (both relative and absolute) to align with the reorganized AppIDE structure.
Various files under app/client/src/pages/AppIDE/... (e.g., EditorPane, LeftPane, MainPane, Header, Layout, etc.) Updated relative path resolutions and component references as part of restructuring the file organization from Editor/IDE to AppIDE.

Possibly related PRs

Suggested labels

ok-to-test, Task, IDE Pod

Suggested reviewers

  • albinAppsmith
  • ankitakinger

Poem

In the maze of code we now traverse,
Paths realign with a structured verse,
From Editor/IDE to AppIDE we steer,
Exports and imports made crystal clear,
A reorganization song to code’s eternal cheer 🚀
Structure renewed, our code shines sincere!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5bd302 and 319c8bb.

📒 Files selected for processing (82)
  • app/client/src/ce/navigation/FocusSetters.ts (1 hunks)
  • app/client/src/ce/pages/AppIDE/EditorPane/JS/ListItem.tsx (1 hunks)
  • app/client/src/ce/pages/AppIDE/EditorPane/JS/hooks.tsx (3 hunks)
  • app/client/src/ce/pages/AppIDE/EditorPane/JS/utils/getJSContextMenuByIdeType.tsx (1 hunks)
  • app/client/src/ce/pages/AppIDE/EditorPane/Query/ListItem.tsx (1 hunks)
  • app/client/src/ce/pages/AppIDE/EditorPane/Query/hooks.tsx (5 hunks)
  • app/client/src/ce/pages/AppIDE/EditorPane/Query/utils/getQueryContextMenuByIdeType.tsx (1 hunks)
  • app/client/src/ce/pages/AppIDE/LeftPane/LibrarySidePane.tsx (1 hunks)
  • app/client/src/ce/pages/common/AppHeader.tsx (1 hunks)
  • app/client/src/ce/selectors/appIDESelectors.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/JS/ListItem.tsx (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/JS/hooks.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/JS/old/ListItem.tsx (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/JS/utils/getJSContextMenuByIdeType.tsx (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/JS/utils/getJSEntityItemUrl.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/JS/utils/getJSUrl.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/Query/ListItem.tsx (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/Query/hooks.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/Query/old/ListItem.tsx (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/Query/utils/getQueryContextMenuByIdeType.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/Query/utils/getQueryEntityItemUrl.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/Query/utils/getQueryUrl.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/EditorPane/constants.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/Header/useLibraryHeaderTitle.ts (1 hunks)
  • app/client/src/ee/pages/AppIDE/LeftPane/LibrarySidePane.tsx (1 hunks)
  • app/client/src/ee/pages/AppIDE/MainPane/useMissingModuleNotification.tsx (1 hunks)
  • app/client/src/ee/pages/AppIDE/MainPane/useRoutes.ts (1 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/JS/ListItem.tsx (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/JS/hooks.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/JS/old/ListItem.tsx (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/JS/utils/getJSContextMenuByIdeType.tsx (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/JS/utils/getJSEntityItemUrl.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/JS/utils/getJSUrl.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/Query/ListItem.tsx (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/Query/hooks.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/Query/old/ListItem.tsx (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/Query/utils/getQueryContextMenuByIdeType.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/Query/utils/getQueryEntityItemUrl.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/Query/utils/getQueryUrl.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/EditorPane/constants.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/Header/useLibraryHeaderTitle.ts (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/LeftPane/LibrarySidePane.tsx (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/MainPane/useMissingModuleNotification.tsx (0 hunks)
  • app/client/src/ee/pages/Editor/IDE/MainPane/useRoutes.ts (0 hunks)
  • app/client/src/layoutSystems/common/dropTarget/OnBoarding/OnBoarding.test.tsx (1 hunks)
  • app/client/src/pages/AppIDE/AppsmithIDE.test.tsx (2 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Editor.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Explorer.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/JS/Add.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/JS/BlankState.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/JS/Editor.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/JS/EntityItem/JSEntityItem.tsx (2 hunks)
  • app/client/src/pages/AppIDE/EditorPane/JS/JSRender.test.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/JS/List.tsx (2 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Pages/PageElement.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Query/Add.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Query/BlankState.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Query/Editor.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Query/EntityItem/QueryEntityItem.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Query/List.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/Query/QueryRender.test.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/UI/List.test.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorPane/UI/UIRender.test.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorTabs/AddButton.tsx (1 hunks)
  • app/client/src/pages/AppIDE/EditorTabs/constants.ts (1 hunks)
  • app/client/src/pages/AppIDE/Header/index.tsx (1 hunks)
  • app/client/src/pages/AppIDE/Layout/StaticLayout.tsx (1 hunks)
  • app/client/src/pages/AppIDE/LeftPane/AddLibraryPopover.tsx (1 hunks)
  • app/client/src/pages/AppIDE/LeftPane/AppSettings.tsx (1 hunks)
  • app/client/src/pages/AppIDE/LeftPane/JSLibrariesSection.tsx (1 hunks)
  • app/client/src/pages/AppIDE/LeftPane/index.tsx (1 hunks)
  • app/client/src/pages/AppIDE/MainPane/index.tsx (1 hunks)
  • app/client/src/pages/AppIDE/ProtectedCallout.test.tsx (1 hunks)
  • app/client/src/pages/AppIDE/RightPane/components/CreateNewQueryModal.tsx (1 hunks)
  • app/client/src/pages/AppIDE/hooks.test.tsx (1 hunks)
  • app/client/src/pages/AppIDE/hooks.ts (1 hunks)
  • app/client/src/pages/Editor/CanvasLayoutConversion/hooks/useShowSnapShotBanner.ts (1 hunks)
  • app/client/src/pages/Editor/Explorer/Widgets/WidgetContextMenu.tsx (1 hunks)
  • app/client/src/pages/Editor/GlobalHotKeys/GlobalHotKeys.test.tsx (1 hunks)
  • app/client/src/pages/Editor/JSEditor/AppJSEditorContextMenu.tsx (1 hunks)
  • app/client/src/pages/Editor/WidgetsEditor/WidgetEditorContainer.tsx (1 hunks)
  • app/client/src/pages/Editor/WidgetsEditor/WidgetEditorHeader.tsx (1 hunks)
⛔ Files not processed due to max files limit (12)
  • app/client/src/pages/Editor/WidgetsEditor/components/CodeModeTooltip.tsx
  • app/client/src/pages/Editor/WidgetsEditor/components/NavigationAdjustedPageViewer.tsx
  • app/client/src/pages/Editor/WidgetsEditor/components/NavigationPreview.tsx
  • app/client/src/pages/Editor/WidgetsEditor/components/PropertyPaneWrapper.tsx
  • app/client/src/pages/Editor/WidgetsEditor/components/WidgetEditorNavigation.tsx
  • app/client/src/pages/Editor/commons/EditorSettingsPaneContainer.tsx
  • app/client/src/pages/Editor/commons/EditorWrapperContainer.tsx
  • app/client/src/pages/Editor/index.tsx
  • app/client/src/sagas/IDESaga.tsx
  • app/client/src/selectors/jsPaneSelectors.ts
  • app/client/src/utils/hooks/useHoverToFocusWidget.ts
  • app/client/test/testMockedWidgets.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Feb 4, 2025
@hetunandu hetunandu closed this Feb 6, 2025
@hetunandu hetunandu marked this pull request as ready for review February 6, 2025 06:42
@hetunandu hetunandu requested a review from a team February 6, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant