Skip to content

chore: added buckets for all appsmith metrics#38962

Merged
ApekshaBhosale merged 1 commit intoreleasefrom
add-buckets-all-appsmith-metrics
Feb 3, 2025
Merged

chore: added buckets for all appsmith metrics#38962
ApekshaBhosale merged 1 commit intoreleasefrom
add-buckets-all-appsmith-metrics

Conversation

@ApekshaBhosale
Copy link
Contributor

@ApekshaBhosale ApekshaBhosale commented Feb 3, 2025 •
edited by github-actions bot
Loading

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13111416304
Commit: f05f7cd
Cypress dashboard.
Tags: @tag.All
Spec:

Mon, 03 Feb 2025 12:42:58 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Added a new configuration setting that adjusts metrics distribution thresholds to support improved system monitoring.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2025 •
edited
Loading

Walkthrough

The pull request introduces a new configuration property in the application.properties file for the Appsmith server. The property, management.metrics.distribution.slo.appsmith, is added with a set of numerical values. This update establishes a new metrics distribution for monitoring service level objectives without modifying any existing entries.

Changes

File Path Change Summary
app/server/appsmith-server/src/main/.../application.properties Added a new configuration property management.metrics.distribution.slo.appsmith with metric values

Possibly related PRs

Suggested labels

skip-changelog

Suggested reviewers

  • nidhi-nair
  • sharat87

Poem

In the realm of code and keys,
A new property takes its stance with ease.
Metrics line up, numbers in a row,
Ensuring performance's steady flow.
Cheers to config magic—let improvement glow!
🚀✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ApekshaBhosale ApekshaBhosale added the ok-to-test Required label for CI label Feb 3, 2025
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Feb 3, 2025
coderabbitai[bot]
coderabbitai bot reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/server/appsmith-server/src/main/resources/application.properties (1)

99-99: New SLO Bucket Property Added for Appsmith Metrics

The property management.metrics.distribution.slo.appsmith=100,200,500,1000,2000,5000,10000,20000,30000 is introduced with the same distribution buckets used for HTTP server requests. Please verify that these bucket ranges are the intended values for Appsmith metrics and consider adding an inline comment or documentation reference explaining its purpose for future maintainability.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb3132 and f05f7cd.

📒 Files selected for processing (1)
  • app/server/appsmith-server/src/main/resources/application.properties (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: server-unit-tests / server-unit-tests
  • GitHub Check: build
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Failed server tests

  • com.appsmith.server.fork.ApplicationForkingServiceTests#cloneApplicationForkWithConfigurationFalseWithActionsThrice

@ApekshaBhosale ApekshaBhosale merged commit a7d31b5 into release Feb 3, 2025
89 checks passed
@ApekshaBhosale ApekshaBhosale deleted the add-buckets-all-appsmith-metrics branch February 3, 2025 13:29
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025
@ApekshaBhosale
chore: added buckets for all appsmith metrics (appsmithorg#38962)
41198c9 
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13111416304>
> Commit: f05f7cd
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13111416304&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 03 Feb 2025 12:42:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Added a new configuration setting that adjusts metrics distribution
thresholds to support improved system monitoring.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

+1 more reviewer

@nidhi-nair nidhi-nair nidhi-nair approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ApekshaBhosale @nidhi-nair