chore: update select component #38954
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -52,13 +52,13 @@ describe( | |||||
|
|
||||||
| it("3. Validate DataType - NUMBER can be entered into Input widget", () => { | ||||||
| cy.openPropertyPane(widgetName); | ||||||
| cy.selectDropdownValue(".t--property-control-datatype", "Number"); | ||||||
|
|
||||||
| cy.get(".t--property-control-required label") | ||||||
| .last() | ||||||
| .click({ force: true }); | ||||||
|
|
||||||
| cy.selectDropdownValue(".t--property-control-datatype", "Number"); | ||||||
|
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Remove duplicate dropdown selection. The dropdown value is already selected in line 55. This duplicate selection is unnecessary. -cy.selectDropdownValue(".t--property-control-datatype", "Number");📝 Committable suggestion
Suggested change
|
||||||
| [ | ||||||
| { | ||||||
| input: "invalid", | ||||||
|
|
@@ -101,7 +101,7 @@ describe( | |||||
|
|
||||||
| it("4. Validate DataType - PASSWORD can be entered into Input widget", () => { | ||||||
| cy.openPropertyPane(widgetName); | ||||||
| cy.selectDropdownValue(".t--property-control-datatype", "Password"); | ||||||
| [ | ||||||
| { | ||||||
| input: "test", | ||||||
|
|
@@ -136,7 +136,7 @@ describe( | |||||
|
|
||||||
| it("5. Validate DataType - EMAIL can be entered into Input widget", () => { | ||||||
| cy.openPropertyPane(widgetName); | ||||||
| cy.selectDropdownValue(".t--property-control-datatype", "Email"); | ||||||
|
|
||||||
| cy.get(".t--property-control-required label") | ||||||
| .last() | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ describe( | |
| cy.wait(300); | ||
| cy.get(widgetInput).should("contain.value", ""); | ||
|
|
||
| cy.selectDropdownValue(".t--property-control-datatype", "Number"); | ||
|
|
||
| cy.get(widgetInput).clear(); | ||
| cy.get(widgetInput).type("1.0010{enter}"); //Clicking enter submits the form here | ||
|
|
@@ -37,7 +37,7 @@ describe( | |
|
|
||
| it("3. Validate DataType - TEXT can be entered into Input widget", () => { | ||
| cy.selectDropdownValue( | ||
| ".t--property-control-datatype", | ||
| "Single-line text", | ||
| ); | ||
| [ | ||
|
|
@@ -112,7 +112,7 @@ describe( | |
|
|
||
| it("4. Validate DataType - NUMBER can be entered into Input widget", () => { | ||
| cy.openPropertyPane(widgetName); | ||
| cy.selectDropdownValue(".t--property-control-datatype", "Number"); | ||
| [ | ||
| { | ||
| input: "invalid", | ||
|
|
@@ -157,7 +157,7 @@ describe( | |
| .last() | ||
| .click({ force: true }); | ||
|
|
||
| cy.selectDropdownValue(".t--property-control-datatype", "Number"); | ||
| [ | ||
| { | ||
| input: "invalid", | ||
|
|
@@ -200,7 +200,7 @@ describe( | |
|
|
||
| it("5. Validate DataType - PASSWORD can be entered into Input widget", () => { | ||
| cy.openPropertyPane(widgetName); | ||
| cy.selectDropdownValue(".t--property-control-datatype", "Password"); | ||
| [ | ||
| { | ||
| input: "test", | ||
|
|
@@ -273,7 +273,7 @@ describe( | |
|
|
||
| it("6. Validate DataType - EMAIL can be entered into Input widget", () => { | ||
| cy.openPropertyPane(widgetName); | ||
| cy.selectDropdownValue(".t--property-control-datatype", "Email"); | ||
| [ | ||
| { | ||
| input: "test", | ||
|
|
@@ -361,7 +361,7 @@ describe( | |
| it("8. onSubmit should be triggered with the whole input value", () => { | ||
| cy.openPropertyPane(widgetName); | ||
| cy.selectDropdownValue( | ||
| ".t--property-control-datatype", | ||
| "Single-line text", | ||
| ); | ||
| cy.get(".t--property-control-required label") | ||
|
|
@@ -415,7 +415,7 @@ describe( | |
| "anotherText:anotherText:true", | ||
| ); | ||
|
|
||
| cy.selectDropdownValue(".t--property-control-datatype", "Number"); | ||
|
|
||
| cy.updateCodeInput(".t--property-control-defaultvalue", `{{1}}`); | ||
| // wait for evaluations | ||
|
|
@@ -439,7 +439,7 @@ describe( | |
| // Init isDirty | ||
| cy.openPropertyPane(widgetName); | ||
| cy.selectDropdownValue( | ||
| ".t--property-control-datatype", | ||
| "Single-line text", | ||
| ); | ||
| cy.updateCodeInput(".t--property-control-defaultvalue", "a"); | ||
|
|
@@ -490,7 +490,7 @@ describe( | |
| cy.get(widgetInput).should("have.attr", "autocomplete", "off"); | ||
|
|
||
| //select a non email or password option | ||
| cy.selectDropdownValue(".t--property-control-datatype", "text"); | ||
| //autofill toggle should not be present as this restores autofill to be enabled | ||
| cy.get(".t--property-control-allowautofill input").should("not.exist"); | ||
| //autocomplete attribute should not be present in the text widget | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,17 +2,7 @@ import * as _ from "../../../../../support/Objects/ObjectsCore"; | |
|
|
||
| const widgetName = "phoneinputwidget"; | ||
| const widgetInput = `.t--widget-${widgetName} input`; | ||
|
|
||
| describe( | ||
| "Phone input widget - ", | ||
| { tags: ["@tag.Widget", "@tag.PhoneInput", "@tag.Binding"] }, | ||
|
|
@@ -21,7 +11,7 @@ describe( | |
| _.agHelper.AddDsl("emptyDSL"); | ||
| }); | ||
|
|
||
| it("1. Add new phone input widget", () => { | ||
| cy.dragAndDropToCanvas(widgetName, { x: 300, y: 300 }); | ||
| cy.get(`.t--widget-${widgetName}`).should("exist"); | ||
| cy.dragAndDropToCanvas("textwidget", { x: 300, y: 500 }); | ||
|
|
@@ -39,7 +29,12 @@ describe( | |
| cy.get(".t--widget-textwidget").should("contain", "(999) 999-9999:US:+1"); | ||
|
|
||
| cy.openPropertyPane(widgetName); | ||
| cy.openSelectDropdown(".t--property-control-defaultcountrycode"); | ||
| cy.searchSelectDropdown("Afg"); | ||
| cy.selectDropdownValue( | ||
| ".t--property-control-defaultcountrycode", | ||
| "Afghanistan (+93)", | ||
| ); | ||
| cy.get(`.t--widget-${widgetName} input`).clear(); | ||
| cy.wait(500); | ||
| cy.get(`.t--widget-${widgetName} input`).type("1234567890"); | ||
|
|
@@ -62,14 +57,24 @@ describe( | |
| cy.get(".t--property-control-enableformatting label") | ||
| .last() | ||
| .click({ force: true }); | ||
| cy.openSelectDropdown(".t--property-control-defaultcountrycode"); | ||
| cy.searchSelectDropdown("United States / Canada"); | ||
| cy.selectDropdownValue( | ||
| ".t--property-control-defaultcountrycode", | ||
| "United States / Canada (+1)", | ||
| ); | ||
| cy.get(`.t--widget-${widgetName} input`).clear(); | ||
| cy.wait(500); | ||
| cy.get(`.t--widget-${widgetName} input`).type("9999999999"); | ||
| cy.get(".t--widget-textwidget").should("contain", "9999999999:US:+1"); | ||
|
|
||
| cy.openPropertyPane(widgetName); | ||
| cy.openSelectDropdown(".t--property-control-defaultcountrycode"); | ||
| cy.searchSelectDropdown("India"); | ||
| cy.selectDropdownValue( | ||
| ".t--property-control-defaultcountrycode", | ||
| "India (+91)", | ||
| ); | ||
| cy.get(`.t--widget-${widgetName} input`).clear(); | ||
| cy.wait(500); | ||
| cy.get(`.t--widget-${widgetName} input`).type("1234567890"); | ||
|
|
@@ -131,13 +136,11 @@ describe( | |
|
|
||
| // Select the Currency dropdown option from property pane | ||
| // and enter a value that has space and returns 0 results | ||
| cy.openSelectDropdown(".t--property-control-defaultcountrycode"); | ||
| cy.searchSelectDropdown("AFDB"); | ||
|
|
||
| // assert that the dropdown is still option | ||
| cy.get(".ads-v2-select__dropdown .rc-select-item-empty").should( | ||
| "be.visible", | ||
| ); | ||
| }); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "imageWidget": ".t--draggable-imagewidget", | ||
| "chartWidget": ".t--draggable-chartwidget", | ||
| "chartType": ".t--property-control-charttype", | ||
| "chartTypeText": ".t--property-control-charttype", | ||
| "mapType": ".t--property-control-maptype .rc-select-selection-item", | ||
| "destin": ".appsmith_widget_01ewdomru7", | ||
|
|
@@ -36,4 +36,4 @@ | |
| "pickMyLocation": ".t--draggable-mapwidget div[title='Pick My Location']", | ||
| "mapChartEntityLabels": ".t--draggable-mapchartwidget text", | ||
| "listWidget": ".t--draggable-listwidget" | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use data- attributes for selectors.*
According to the coding guidelines, use data-* attributes instead of class selectors.
Example refactor:
Also applies to: 39-39, 40-40, 41-41, 42-42, 43-43, 44-44