chore: move the rts.conf code to shell file by nsarupr · Pull Request #38859 · appsmithorg/appsmith

nsarupr · 2025-01-28T05:17:15Z

Description

Tip

Moving the rts.conf running code to shell file for more extensibility.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13004107300
Commit: b8af6b5
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Tue, 28 Jan 2025 05:59:53 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Deployment
- Added a new shell script (run-rts.sh) to manage the execution of the Node.js application
- Updated supervisord configuration to use the new shell script for running the application

coderabbitai · 2025-01-28T05:17:23Z

Walkthrough

A new shell script run-rts.sh has been introduced in the Docker deployment configuration to execute a Node.js application. The script is a simple wrapper that runs the RTS (Real-Time Services) server using the exec command to launch the Node.js application directly. Correspondingly, the supervisord configuration for the RTS process has been updated to use this new shell script.

Changes

File	Change Summary
`deploy/docker/fs/opt/appsmith/run-rts.sh`	New shell script created with `#!/bin/bash` and `exec node /opt/appsmith/rts/bundle/server.js`
`deploy/docker/fs/opt/appsmith/templates/supervisord/application_process/rts.conf`	Updated command to use new `run-rts.sh` script

Possibly related PRs

chore: Trigger TBP on pg for scheduled run on release #36399: Directly related to the introduction of the run-rts.sh script
chore: Read mail env variables only when needed #37660: Involves RTS component modifications

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

sharat87
pratapaprasanna

Poem

🚀 A script so lean, a command so clean
Exec node with grace, in its rightful place
RTS dancing to supervisord's beat
Deployment magic, now complete!
🔧 Simplicity wins the day

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

deploy/docker/fs/opt/appsmith/templates/supervisord/application_process/rts.conf (1)
2-2: Consider adding error handling to the shell script.

Since this is a critical service startup script, consider adding basic error handling in run-rts.sh.

Add these checks to the shell script:
 #!/bin/bash
+
+if [ ! -f "/opt/appsmith/rts/bundle/server.js" ]; then
+    echo "Error: RTS server.js not found"
+    exit 1
+fi
+
 exec node /opt/appsmith/rts/bundle/server.js

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 235a0ed and b8af6b5.

📒 Files selected for processing (2)

deploy/docker/fs/opt/appsmith/run-rts.sh (1 hunks)
deploy/docker/fs/opt/appsmith/templates/supervisord/application_process/rts.conf (1 hunks)

✅ Files skipped from review due to trivial changes (1)

deploy/docker/fs/opt/appsmith/run-rts.sh

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: perform-test / rts-build / build
GitHub Check: perform-test / client-build / client-build
GitHub Check: perform-test / server-build / server-unit-tests

🔇 Additional comments (1)

deploy/docker/fs/opt/appsmith/templates/supervisord/application_process/rts.conf (1)

2-2: Verify shell script setup and permissions.

The change to use a wrapper script improves extensibility. However, ensure the following:

The shell script exists at /opt/appsmith/run-rts.sh

The script has proper executable permissions

nsarupr · 2025-01-28T05:54:53Z

/build-deploy-preview skip-tests=true

github-actions · 2025-01-28T05:55:17Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13004493587.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38859.
recreate: .

github-actions · 2025-01-28T06:00:59Z

Deploy-Preview-URL: https://ce-38859.dp.appsmith.com

move the rts.conf code to shell file

b8af6b5

nsarupr requested review from pratapaprasanna and sharat87 as code owners January 28, 2025 05:17

nsarupr self-assigned this Jan 28, 2025

nsarupr added the ok-to-test Required label for CI label Jan 28, 2025

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 28, 2025

coderabbitai bot reviewed Jan 28, 2025

View reviewed changes

sharat87 approved these changes Jan 28, 2025

View reviewed changes

nsarupr merged commit 83ce2d6 into release Jan 28, 2025
45 checks passed

nsarupr deleted the chore/move-to-shell-for-rts-conf branch January 28, 2025 06:23

coderabbitai bot mentioned this pull request Feb 6, 2025

chore: Enable source maps for RTS for better error traces #39099

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move the rts.conf code to shell file#38859

chore: move the rts.conf code to shell file#38859
nsarupr merged 1 commit intoreleasefrom
chore/move-to-shell-for-rts-conf

nsarupr commented Jan 28, 2025 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Jan 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

nsarupr commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nsarupr commented Jan 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

nsarupr commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nsarupr commented Jan 28, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Jan 28, 2025 •

edited

Loading