chore: remove deprecated feature flag for custom loading state in TableWidget

[rahulbarwal]

Description

• Removed the release_table_custom_loading_state_enabled feature flag from FeatureFlag.ts and its references in TableWidgetV2 components.
• Updated property configurations to eliminate reliance on the deprecated flag, streamlining the widget's loading state handling.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Table"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12943660031
Commit: ebf8e03
Cypress dashboard.
Tags: @tag.Table
Spec:

---

Fri, 24 Jan 2025 05:46:41 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Feature Flag Removal

  • Removed release_table_custom_loading_state_enabled feature flag
  • Eliminated custom loading state configuration for table widget

• Configuration Updates

  • Made customIsLoading property always visible
  • Added expandedByDefault: true to "Data" section in table widget configuration

[coderabbitai]

Walkthrough

This pull request involves removing the release_table_custom_loading_state_enabled feature flag from the application. The changes primarily impact the TableWidgetV2 component, removing references to the feature flag in the FeatureFlag.ts, constants.ts, and contentConfig.ts files. The modification simplifies the configuration by making the customIsLoading property always visible and adding an expandedByDefault property to the "Data" section.

Changes

File	Change Summary
app/client/src/ce/entities/FeatureFlag.ts	Removed release_table_custom_loading_state_enabled feature flag and its default value
app/client/src/widgets/TableWidgetV2/constants.ts	Deleted CUSTOM_LOADING_STATE_ENABLED constant
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/contentConfig.ts	Removed feature flag import, modified customIsLoading hidden property, added expandedByDefault: true to "Data" section

Possibly related PRs

• chore: Removes GA feature flag release_show_partial_import_export_enabled #33563: Removes another feature flag similar to this one
• feat: remove release_table_cell_label_value_enabled feature flag #37110: Removes a table-related feature flag
• feat: Update TableWidgetV2 to include customIsLoading property #36857: Previously introduced the feature flag now being removed

Suggested Labels

Enhancement, Widgets Product, Table Widget V2, ok-to-test, Needs Triaging, skip-changelog

Suggested Reviewers

• ApekshaBhosale
• jacquesikot

Poem

🏁 Feature flags come and go,
Like whispers in the code's soft flow
One flag fades, another takes flight
Simplifying configs, making things light!
🧹 Cleanup complete, widget's now free

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/widgets/TableWidgetV2/widget/propertyConfig/contentConfig.ts (1)

Line range hint 123-130: Consider consolidating section expansion properties.

The comment indicates that expandedByDefault is a temporary solution alongside the existing isDefaultOpen property. This creates technical debt and potential confusion.

Consider one of these approaches:

1. Use the existing isDefaultOpen property with a flag-based default value
2. Document a timeline for consolidating these properties

-    // Added this prop to indicate that data section needs to be expanded by default
-    // Rest all sections needs to be collapsed
-    // We already have a isDefaultOpen prop configured to keep a section expanded or not
-    // but introducing new prop so that we can control is based on flag
-    // Once we decide to keep this feature, we can go back to using isDefaultOpen and removeexpandedByDefault
     expandedByDefault: true,
+    // TODO(tech-debt): Consolidate with isDefaultOpen property by Q2 2025
+    expandedByDefault: true,

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c632b5 and ebf8e03.

📒 Files selected for processing (3)

• app/client/src/ce/entities/FeatureFlag.ts (0 hunks)
• app/client/src/widgets/TableWidgetV2/constants.ts (0 hunks)
• app/client/src/widgets/TableWidgetV2/widget/propertyConfig/contentConfig.ts (1 hunks)

💤 Files with no reviewable changes (2)

• app/client/src/widgets/TableWidgetV2/constants.ts
• app/client/src/ce/entities/FeatureFlag.ts

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / rts-build / build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-build / client-build
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies

🔇 Additional comments (1)

app/client/src/widgets/TableWidgetV2/widget/propertyConfig/contentConfig.ts (1)

Line range hint 449-474: LGTM: Clean implementation of custom loading state.

The removal of the feature flag has simplified the configuration while maintaining the feature's functionality. The dependency between customIsLoading and customIsLoadingValue is properly maintained.