-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: Replace entities in entity explorer with new ADS templates #38750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ankitakinger
merged 34 commits into
release
from
chore/replace-entities-in-entity-explorer
Jan 24, 2025
Merged
Changes from 28 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
49971b1
replacing query list items with the new ADS entity item and entity gr…
ankitakinger 580638b
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 40ba4f9
removing duplicate hook
ankitakinger 4f1382e
updating variabkle
ankitakinger fce6aef
minor change
ankitakinger d7b7400
re-structuring folders
ankitakinger fcf3f36
fixing tests
ankitakinger 3f86ad9
adding classname
ankitakinger 7ad220c
creating hooks for context menu and create action permissions
ankitakinger 625a466
clearing warnings
ankitakinger e2719d1
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger aa2cff6
updating import
ankitakinger 007bbcb
updating import
ankitakinger d346aa9
restructuring components to reuse menu items
ankitakinger dad304b
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 5aa02b8
minor changes
ankitakinger 2764f44
updating disabled state for menu items
ankitakinger 3b79140
removing unused constants
ankitakinger 1580e0f
resolving dependencies
ankitakinger c818f45
replaced JS entities with new ADS templates in entity explorer
ankitakinger aec5a5e
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger ae89757
removing hideIcon prop
ankitakinger 67850c7
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 0115c6a
refactoring file and folder structure
ankitakinger afdd229
type changes
ankitakinger f0306d5
renaming variables
ankitakinger 216dc51
fixing client build
ankitakinger 4e74792
addressing coderabbitai comments
ankitakinger d321cf7
handling EE case for js entity deletion
ankitakinger 21ae1aa
updating dependency array
ankitakinger cb36e5f
removing convert to module for js object
ankitakinger adb532c
redirecting to page when workflow query is moved to that page
ankitakinger 9e4c0d1
addressing review comments
ankitakinger bf508e2
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 3 additions & 23 deletions
26
app/client/src/ce/pages/Editor/IDE/EditorPane/JS/ListItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,7 @@ | ||
| import React from "react"; | ||
| import ExplorerJSCollectionEntity from "pages/Editor/Explorer/JSActions/JSActionEntity"; | ||
| import { Flex } from "@appsmith/ads"; | ||
| import type { EntityItem } from "ee/entities/IDE/constants"; | ||
| import { JSEntityItem } from "pages/Editor/IDE/EditorPane/JS/EntityItem/JSEntityItem"; | ||
|
|
||
| export interface JSListItemProps { | ||
| item: EntityItem; | ||
| isActive: boolean; | ||
| parentEntityId: string; | ||
| } | ||
|
|
||
| export const JSListItem = (props: JSListItemProps) => { | ||
| const { isActive, item, parentEntityId } = props; | ||
|
|
||
| return ( | ||
| <Flex data-testid="t--ide-list-item" flexDirection={"column"}> | ||
| <ExplorerJSCollectionEntity | ||
| baseCollectionId={item.key} | ||
| isActive={isActive} | ||
| key={item.key} | ||
| parentEntityId={parentEntityId} | ||
| searchKeyword={""} | ||
| step={1} | ||
| /> | ||
| </Flex> | ||
| ); | ||
| export const JSEntity = (props: { item: EntityItem }) => { | ||
| return <JSEntityItem {...props} />; | ||
| }; |
27 changes: 27 additions & 0 deletions
27
app/client/src/ce/pages/Editor/IDE/EditorPane/JS/old/ListItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import React from "react"; | ||
| import ExplorerJSCollectionEntity from "pages/Editor/Explorer/JSActions/JSActionEntity"; | ||
| import { Flex } from "@appsmith/ads"; | ||
| import type { EntityItem } from "ee/entities/IDE/constants"; | ||
|
|
||
| export interface JSListItemProps { | ||
| item: EntityItem; | ||
| isActive: boolean; | ||
| parentEntityId: string; | ||
| } | ||
|
|
||
| export const JSListItem = (props: JSListItemProps) => { | ||
| const { isActive, item, parentEntityId } = props; | ||
|
|
||
| return ( | ||
| <Flex data-testid="t--ide-list-item" flexDirection={"column"}> | ||
| <ExplorerJSCollectionEntity | ||
| baseCollectionId={item.key} | ||
| isActive={isActive} | ||
| key={item.key} | ||
| parentEntityId={parentEntityId} | ||
| searchKeyword={""} | ||
| step={1} | ||
| /> | ||
| </Flex> | ||
| ); | ||
| }; |
20 changes: 20 additions & 0 deletions
20
app/client/src/ce/pages/Editor/IDE/EditorPane/JS/utils/getJSContextMenuByIdeType.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import React from "react"; | ||
| import { IDE_TYPE, type IDEType } from "ee/entities/IDE/constants"; | ||
| import EntityContextMenu from "pages/Editor/IDE/EditorPane/components/EntityContextMenu"; | ||
| import { AppJSContextMenuItems } from "pages/Editor/IDE/EditorPane/JS/EntityItem/AppJSContextMenuItems"; | ||
| import type { JSCollection } from "entities/JSCollection"; | ||
|
|
||
| export const getJSContextMenuByIdeType = ( | ||
| ideType: IDEType, | ||
| jsAction: JSCollection, | ||
| ) => { | ||
| switch (ideType) { | ||
| case IDE_TYPE.App: { | ||
| return ( | ||
| <EntityContextMenu | ||
| menuContent={<AppJSContextMenuItems jsAction={jsAction} />} | ||
| /> | ||
| ); | ||
| } | ||
| } | ||
| }; | ||
24 changes: 3 additions & 21 deletions
24
app/client/src/ce/pages/Editor/IDE/EditorPane/Query/ListItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,7 @@ | ||
| import React from "react"; | ||
| import ExplorerActionEntity from "pages/Editor/Explorer/Actions/ActionEntity"; | ||
| import { QueryEntityItem } from "pages/Editor/IDE/EditorPane/Query/EntityItem/QueryEntityItem"; | ||
| import type { EntityItem } from "ee/entities/IDE/constants"; | ||
|
|
||
| export interface QueryListItemProps { | ||
| item: EntityItem; | ||
| isActive: boolean; | ||
| parentEntityId: string; | ||
| } | ||
|
|
||
| export const QueryListItem = (props: QueryListItemProps) => { | ||
| const { isActive, item, parentEntityId } = props; | ||
|
|
||
| return ( | ||
| <ExplorerActionEntity | ||
| baseId={item.key} | ||
| isActive={isActive} | ||
| key={item.key} | ||
| parentEntityId={parentEntityId} | ||
| searchKeyword={""} | ||
| step={1} | ||
| type={item.type} | ||
| /> | ||
| ); | ||
| export const ActionEntityItem = (props: { item: EntityItem }) => { | ||
| return <QueryEntityItem {...props} />; | ||
| }; |
25 changes: 25 additions & 0 deletions
25
app/client/src/ce/pages/Editor/IDE/EditorPane/Query/old/ListItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import React from "react"; | ||
| import ExplorerActionEntity from "pages/Editor/Explorer/Actions/ActionEntity"; | ||
| import type { EntityItem } from "ee/entities/IDE/constants"; | ||
|
|
||
| export interface QueryListItemProps { | ||
| item: EntityItem; | ||
| isActive: boolean; | ||
| parentEntityId: string; | ||
| } | ||
|
|
||
| export const QueryListItem = (props: QueryListItemProps) => { | ||
| const { isActive, item, parentEntityId } = props; | ||
|
|
||
| return ( | ||
| <ExplorerActionEntity | ||
| baseId={item.key} | ||
| isActive={isActive} | ||
| key={item.key} | ||
| parentEntityId={parentEntityId} | ||
| searchKeyword={""} | ||
| step={1} | ||
| type={item.type} | ||
| /> | ||
| ); | ||
| }; |
20 changes: 20 additions & 0 deletions
20
app/client/src/ce/pages/Editor/IDE/EditorPane/Query/utils/getQueryContextMenuByIdeType.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import React from "react"; | ||
| import { IDE_TYPE, type IDEType } from "ee/entities/IDE/constants"; | ||
| import type { Action } from "entities/Action"; | ||
| import { AppQueryContextMenuItems } from "pages/Editor/IDE/EditorPane/Query/EntityItem/AppQueryContextMenuItems"; | ||
| import EntityContextMenu from "pages/Editor/IDE/EditorPane/components/EntityContextMenu"; | ||
|
|
||
| export const getQueryContextMenuByIdeType = ( | ||
| ideType: IDEType, | ||
| action: Action, | ||
| ) => { | ||
| switch (ideType) { | ||
| case IDE_TYPE.App: { | ||
| return ( | ||
| <EntityContextMenu | ||
| menuContent={<AppQueryContextMenuItems action={action} />} | ||
| /> | ||
| ); | ||
| } | ||
| } | ||
| }; | ||
|
ankitakinger marked this conversation as resolved.
|
||
1 change: 1 addition & 0 deletions
1
app/client/src/ee/pages/Editor/IDE/EditorPane/JS/old/ListItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "ce/pages/Editor/IDE/EditorPane/JS/old/ListItem"; |
1 change: 1 addition & 0 deletions
1
app/client/src/ee/pages/Editor/IDE/EditorPane/JS/utils/getJSContextMenuByIdeType.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "ce/pages/Editor/IDE/EditorPane/JS/utils/getJSContextMenuByIdeType"; |
1 change: 1 addition & 0 deletions
1
app/client/src/ee/pages/Editor/IDE/EditorPane/Query/old/ListItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "ce/pages/Editor/IDE/EditorPane/Query/old/ListItem"; |
1 change: 1 addition & 0 deletions
1
app/client/src/ee/pages/Editor/IDE/EditorPane/Query/utils/getQueryContextMenuByIdeType.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "ce/pages/Editor/IDE/EditorPane/Query/utils/getQueryContextMenuByIdeType"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.