ci: Fix for ssh port 22 issue

[sagar-qa007]

Description

Workflow failure : https://github.com/appsmithorg/appsmith/actions/runs/12804875642/job/35705873169

Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38698

Automation

/ok-to-test tags="@tag.Settings"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12807366996
Commit: cc4baab
Cypress dashboard.
Tags: @tag.Settings
Spec:

---

Thu, 16 Jan 2025 11:17:40 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Updated GitHub Actions workflows to disable SSH socket service during Docker container execution
  • Ensures SSH service is stopped and prevented from automatically restarting during CI tests

[coderabbitai]

Walkthrough

The pull request introduces a modification to two GitHub Actions workflow files, .github/workflows/ci-test-limited-with-count.yml and .github/workflows/ci-test-limited.yml. The primary change involves adding a command to disable the SSH socket service during the Docker image run step. This modification aims to prevent SSH access and stop the SSH socket from automatically restarting during the CI test process.

Changes

File	Change Summary
.github/workflows/ci-test-limited-with-count.yml	Added sudo systemctl disable --now ssh.socket to disable SSH socket service
.github/workflows/ci-test-limited.yml	Added sudo systemctl disable --now ssh.socket to disable SSH socket service

Possibly related PRs

• Fix: Fix for GHSL-2024-277 #36836: Modifies the same workflow file by adding a line to disable the SSH socket service
• ci: Checking no_data with contains to avoid error #38592: Enhances input parameter handling and error checking in the workflow file

Suggested labels

bug, ci

Suggested reviewers

• sharat87
• yatinappsmith

Poem

🔒 SSH socket, silent and still
Disabled by command's swift will
CI workflows march on tight
No unexpected access in sight
Security's dance, a careful art 🛡️

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b8ba77 and cc4baab.

📒 Files selected for processing (2)

• .github/workflows/ci-test-limited-with-count.yml (1 hunks)
• .github/workflows/ci-test-limited.yml (1 hunks)

🔇 Additional comments (2)

.github/workflows/ci-test-limited.yml (1)

154-154: LGTM! Comprehensive solution to prevent SSH socket conflicts.

The command properly disables and stops the SSH socket service, preventing automatic restarts during container execution.

Let's verify there are no other SSH-related configurations that might conflict:

✅ Verification successful

Verified: SSH socket configuration is isolated and safe

The change to disable the SSH socket is the only SSH-related configuration in the workflow files, ensuring no conflicts will occur.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any other SSH configurations in workflow files
rg -g '*.yml' -g '*.yaml' 'ssh[.]socket|port.*22|ssh.*start'

Length of output: 62

---

Script:

#!/bin/bash
# Broader search for SSH and systemctl related configurations
rg -g '*.yml' -g '*.yaml' 'systemctl.*ssh|ssh[.]service|ssh.*socket'

# Search for port configurations and SSH keywords
rg -g '*.yml' -g '*.yaml' -i 'port.*22|sshd|openssh'

Length of output: 125

.github/workflows/ci-test-limited-with-count.yml (1)

239-239: LGTM! Consistent implementation across workflows.

The same SSH socket configuration is correctly applied here, maintaining consistency with ci-test-limited.yml.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.