test: fixes failing recaptcha test bey updating key.#38684
test: fixes failing recaptcha test bey updating key.#38684rahulbarwal merged 1 commit intoreleasefrom
Conversation
rahulbarwal
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThis pull request involves a simple update to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/client/cypress/fixtures/testdata.json (1)
143-143: LGTM! The reCAPTCHA key update looks valid.The new key follows the correct format for reCAPTCHA v3. Note that the static analysis warning about API key exposure can be safely ignored as reCAPTCHA site keys are meant to be public.
Consider moving test configuration values like reCAPTCHA keys to environment variables for easier maintenance and key rotation.
Please add a comment documenting the purpose of this key (test environment) and the process for rotating it when it expires.
🧰 Tools
🪛 Gitleaks (8.21.2)
143-143: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/fixtures/testdata.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/fixtures/testdata.json (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🪛 Gitleaks (8.21.2)
app/client/cypress/fixtures/testdata.json
143-143: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: perform-test / rts-build / build
- GitHub Check: client-build / client-build
- GitHub Check: client-lint / client-lint
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
|
/ci-test-limit-count run_count=1 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/Binding/Button_Text_WithRecaptcha_spec.js |
|
/ci-test-limit-count run_count=1 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/Binding/Button_Text_WithRecaptcha_spec.js |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12808180905. |
|
/ci-test-limit-count run_count=20 update_snapshot=false specs_to_run=cypress/e2e/Regression/ClientSide/Binding/Button_Text_WithRecaptcha_spec.js runId=12808180905 |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12809148773. |
rahulbarwal
added
ok-to-test
2 participants
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Binding"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12823216048
Commit: 3510ffa
Cypress dashboard.
Tags:
@tag.BindingSpec:
Fri, 17 Jan 2025 06:55:49 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit