-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore: git api - adding new apis #38681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0888e1d
chore: adding checkout ref
8cfb9ca
chore: adding new apis behind feature flag
3234551
chore: fixing issues with GitBranch
93a1208
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
16a685e
chore: fixing applicationId to artifactId
d0af080
chore: review comment fixes
3791a4a
chore: fixing issue with checkout branch
8f05bbf
chore: review comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
app/client/src/git/components/BranchList/hooks/useFilteredBranches.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import type { GitBranch, GitRef } from "git/types"; | ||
|
|
||
| export default function refToBranchList(refs: GitRef[]): GitBranch[] { | ||
| return refs.map((ref) => ({ | ||
| branchName: ref.refName, | ||
| default: ref.default, | ||
| })); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import type { AxiosPromise } from "axios"; | ||
| import { GIT_BASE_URL } from "./constants"; | ||
| import Api from "api/Api"; | ||
| import type { GitArtifactType } from "git/constants/enums"; | ||
| import type { | ||
| CheckoutRefRequestParams, | ||
| CheckoutRefResponse, | ||
| } from "./checkoutRefRequest.types"; | ||
| import checkoutBranchRequestOld from "./checkoutBranchRequest"; | ||
|
|
||
| async function checkoutRefRequestNew( | ||
| artifactType: GitArtifactType, | ||
| refArtifactid: string, | ||
| params: CheckoutRefRequestParams, | ||
| ): AxiosPromise<CheckoutRefResponse> { | ||
| return Api.post( | ||
| `${GIT_BASE_URL}/${artifactType}/${refArtifactid}/checkout-ref`, | ||
| params, | ||
| ); | ||
| } | ||
|
|
||
| export default async function checkoutRefRequest( | ||
| artifactType: GitArtifactType, | ||
| refArtifactid: string, | ||
| params: CheckoutRefRequestParams, | ||
| isNew: boolean, | ||
| ) { | ||
| if (isNew) { | ||
| return checkoutRefRequestNew(artifactType, refArtifactid, params); | ||
| } else { | ||
| const checkoutBranchParams = { | ||
| branchName: params.refName, | ||
| }; | ||
|
|
||
| return checkoutBranchRequestOld(refArtifactid, checkoutBranchParams); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type { ApiResponse } from "api/types"; | ||
| import type { GitArtifact } from "git/store/types"; | ||
|
|
||
| export interface CheckoutRefRequestParams { | ||
| refType: "branch" | "tag"; | ||
| refName: string; | ||
| message?: string; | ||
| } | ||
|
|
||
| export type CheckoutRefResponseData = GitArtifact; | ||
|
|
||
| export type CheckoutRefResponse = ApiResponse<CheckoutRefResponseData>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import type { AxiosPromise } from "axios"; | ||
| import { GIT_BASE_URL } from "./constants"; | ||
| import Api from "api/Api"; | ||
| import type { GitArtifactType } from "git/constants/enums"; | ||
| import type { | ||
| CreateRefRequestParams, | ||
| CreateRefResponse, | ||
| } from "./createRefRequest.types"; | ||
| import createBranchRequestOld from "./createBranchRequest"; | ||
|
|
||
| async function createRefRequestNew( | ||
| artifactType: GitArtifactType, | ||
| refArtifactId: string, | ||
| params: CreateRefRequestParams, | ||
| ): AxiosPromise<CreateRefResponse> { | ||
| return Api.post( | ||
| `${GIT_BASE_URL}/${artifactType}/${refArtifactId}/create-ref`, | ||
| params, | ||
| ); | ||
| } | ||
|
|
||
| export default async function createRefRequest( | ||
| artifactType: GitArtifactType, | ||
| refArtifactId: string, | ||
| params: CreateRefRequestParams, | ||
| isNew: boolean, | ||
| ) { | ||
| if (isNew) { | ||
| return createRefRequestNew(artifactType, refArtifactId, params); | ||
| } else { | ||
| const createBranchParams = { | ||
| branchName: params.refName, | ||
| }; | ||
|
|
||
| return createBranchRequestOld(refArtifactId, createBranchParams); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.