13/01 Daily Promotion by btsgh · Pull Request #38610 · appsmithorg/appsmith

btsgh · 2025-01-13T08:48:02Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #37453, #37454 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results  > [!WARNING] > Tests have not run on the HEAD ab5e336 yet > <hr>Wed, 08 Jan 2025 07:30:24 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit Based on the comprehensive summary of changes, here are the concise release notes: - **New Features** - Added branch merging capabilities - Enhanced Git reference handling - Introduced new methods for fetching and processing remote Git references - **Improvements** - Updated method signatures across multiple Git-related services - Improved logging and error handling in Git operations - Expanded support for different reference types in schema migrations - **Technical Updates** - Refactored Git file utility methods - Added new Data Transfer Objects (DTOs) for Git operations - Enhanced JSON schema migration processes These changes primarily focus on improving Git integration, providing more flexible reference management, and streamlining the application's version control capabilities.

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: nikhil@appsmith.com <nikhil@appsmith.com>

…e datasources (#38360)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

…nce in EE (#38558)

Co-authored-by: Diljit <diljit@appsmith.com>

…38564) ## Description Make the refName and RefType transient for Artifact class.

Fixes #38525 /ok-to-test tags="@tag.Anvil" https://github.com/user-attachments/assets/891ecf61-2850-46c4-acd3-b170196e5ab7  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12703524629> > Commit: 64616e2 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12703524629&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 10 Jan 2025 05:20:43 UTC   ## Summary by CodeRabbit ## Release Notes - **New Features** - Added form validation controls for buttons - Introduced ability to disable buttons on invalid form - Added option to reset form on button click - New context provider for managing widget state in UI builder - **Improvements** - Enhanced reCAPTCHA handling with reset functionality - Updated button click event management - Improved widget context management - **Configuration Updates** - New form settings for button widgets - Added `useAsForm` configuration for zone widgets These updates provide more granular control over form interactions and button behaviors.

## Description Fix for flaky behaviour. Fixes # https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38568 ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12705899394> > Commit: e193fb3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12705899394&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Fri, 10 Jan 2025 08:50:44 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Tests** - Updated the existing test case to verify accessibility of all admin setting sections. - Enhanced reliability by ensuring a fresh user session before testing admin settings.

## Description - Fixes initial loading state for status - Includes module instances and source module count - Fixes discard flow ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12692930817> > Commit: 6689c8e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12692930817&attempt=4" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Fri, 10 Jan 2025 08:32:22 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Introduced a new focus on source modules instead of packages - Enhanced tracking of module instances and source module changes - **Bug Fixes** - Updated status change calculations to more accurately reflect module modifications - Improved handling of artifact identification in discard operations - **Refactor** - Renamed and restructured various status-related interfaces and functions - Modified selectors and reducers to support new module tracking approach - **Chores** - Updated type definitions and selector implementations - Removed deprecated package-related tracking mechanisms

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>

## Description Adding Group component in ADS Templates to use the same for a single list of grouped entities in the product. Fixes [#37615](#37615) [#37616](#37616) [#38288](#38288) [#38287](#38287) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12704682977> > Commit: b62fecb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12704682977&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 10 Jan 2025 09:11:50 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced List component with improved grouping capabilities. - Added support for dynamic list rendering with custom children. - Introduced `EntityGroupsList` for more flexible group management. - Added new styled components for better visual representation of lists. - Added `LoadMore` styled component for improved UX in entity groups. - New Storybook examples for `EntityGroupsList` and `EntityGroup` components. - **Improvements** - Refined List component to support more flexible item rendering. - Updated styling for list components. - Improved type safety for list-related components. - Streamlined code structure for better maintainability. - **Changes** - Removed `GroupedList` component. - Updated list rendering across multiple components. - Simplified list item management. - Expanded public API for `EntityExplorer` module with new exports.

## Description This changes the dropdown container to fix overflow issues in the Git connect/import modal. The SSH key dropdown now properly scrolls with the modal content instead of remaining fixed in place. ## Type of Change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual testing of dropdown scroll behavior in the Git connect modal Link to Devin run: https://app.devin.ai/sessions/be239c326a7149eaaefe6f6c39d58470 ## Automation /test sanity ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12710679010> > Commit: 40cdbf4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12710679010&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 10 Jan 2025 14:28:55 UTC  Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: arpit@appsmith.com <arpit@appsmith.com>

Added test for import app validation at app level /ok-to-test tags="@tag.All"  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12653467361> > Commit: 1ac6a57 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12653467361&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 08 Jan 2025 04:28:32 UTC   ## Summary by CodeRabbit - **Tests** - Added a new test suite to verify import functionality for applications - Implemented test case to check import options and data source validation at the app level - **New Features** - Added new locators for import button and list item title to support testing  --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>

## Description Found that existing text file was not reading when no_data passed. Fixed the problem by adding that condition. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38591 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12740786426> > Commit: 7c4e548 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12740786426&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Mon, 13 Jan 2025 05:09:41 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Chores** - Updated GitHub Actions workflow for improved test specification handling - Enhanced debug logging and error handling in CI test workflow - Refined mechanism for processing test input sources - Added more robust file checking and fallback logic

## Description RCA: Found the copy the clipboard is not working in chrome. Have enabled spec specific permission for copy and the store the cypress variable in local variable to get firm run results. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38589 ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12740837386> > Commit: e1903db > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12740837386&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Mon, 13 Jan 2025 05:11:28 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Tests** - Updated clipboard handling in end-to-end testing - Improved clipboard permission and content retrieval for test scenarios

…-pane (#38577) ## Description This PR introduces test cases to validate the visibility and correctness of the "Show Bindings" menu when working with JavaScript Objects and API queries in the split-pane mode. It ensures that the bindings are displayed as expected. Tests: #38547 ## Automation /ok-to-test tags="@tag.Datasource, @tag.Sanity, @tag.JS" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12708509894> > Commit: 91840c0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12708509894&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource, @tag.Sanity, @tag.JS` > Spec: > <hr>Fri, 10 Jan 2025 12:29:18 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Added automated tests for validating the "Show Bindings" menu in split pane mode. - Introduced new locators for list toggle and bindings menu. - **Tests** - Created test cases for checking "Show Bindings" functionality for JavaScript Objects and API queries. - **Chores** - Updated test configurations to focus on specific test cases and modified locator references in support files.

…38387) ## Description **Problem** When a table cell is configured with the Select column type, the cell value is not displayed if it does not match any of the label-value pairs in the select options. This results in a broken user experience where it appears as if the cell has no value. **Expected Behaviour** The table cell should always display its value if it exists, regardless of whether it matches the provided select options. **Solution** To address this issue, the default behaviour for the select options has been updated to prioritise the cell's value instead of falling back to an empty string. This ensures that cell values are always visible to the user, even if they are not part of the predefined select options. Fixes #35807 ## Automation /ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding, @tag.Table, @tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12544985047> > Commit: d39d7f3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12544985047&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Select, @tag.Binding, @tag.Table, @tag.Sanity` > Spec: > <hr>Mon, 30 Dec 2024 11:52:44 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Bug Fixes** - Improved display logic in the SelectCell component to show the value when no matching option is found. - Updated test cases for the Select column type functionality to ensure accurate verification of select options and display behavior when options are not provided.

## Summary by CodeRabbit - **Tests** - Updated Cypress test suite for import functionality - Added tag to exclude test in specific environments  Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>

Co-authored-by: Ankita Kinger <ankita@appsmith.com>

coderabbitai · 2025-01-13T08:48:10Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hetunandu and others added 26 commits January 8, 2025 17:25

chore: Housekeeping items in List and Entity Item ADS (#38537)

8efce1d

chore: update map defaults to NYC coords (#38545)

5978a96

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: nikhil@appsmith.com <nikhil@appsmith.com>

chore: make cyclic deps check an error (#38543)

4662317

fix: Show bindings hiding behind scroll (#38553)

c302b64

feat: datasource homepage ui redesign and search functionality for th…

dfd7fde

…e datasources (#38360)

fix: UsagePulse initialisation flow (#38555)

388fd81

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

fix: Updating CSS for list item to fix UI breaking on JS module insta…

6446f46

…nce in EE (#38558)

chore: Update upload-artifact version to v4

ee51fbd

chore: Separate files for Redux Types (#38559)

c155a51

Co-authored-by: Diljit <diljit@appsmith.com>

chore: make refName and refType transient in Artifact Metadata class (#…

37354bc

…38564) ## Description Make the refName and RefType transient for Artifact class.

chore: update client-build github runner (#38571)

e12f1bc

fix: Response view not passing error to support (#38579)

5a17a7f

feat: add setText setter to PhoneInputWidget (#38578)

ca26549

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>

feat: ADS Entity List Tree (#38493)

f8784fc

Co-authored-by: Ankita Kinger <ankita@appsmith.com>

btsgh requested a review from shadabbuchh January 13, 2025 08:48

btsgh requested review from ApekshaBhosale, sagar-qa007 and sharat87 as code owners January 13, 2025 08:48

btsgh requested review from a team, ankitakinger and ayushpahwa as code owners January 13, 2025 08:48

btsgh requested a review from a team January 13, 2025 08:48

btsgh requested a review from a team as a code owner January 13, 2025 08:48

btsgh requested review from rahulbarwal and removed request for a team January 13, 2025 08:48

shadabbuchh approved these changes Jan 13, 2025

View reviewed changes

rahulbarwal approved these changes Jan 13, 2025

View reviewed changes

btsgh merged commit c7197af into master Jan 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

13/01 Daily Promotion#38610

13/01 Daily Promotion#38610
btsgh merged 26 commits intomasterfrom
release

btsgh commented Jan 13, 2025

Uh oh!

coderabbitai bot commented Jan 13, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Conversation

btsgh commented Jan 13, 2025

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Jan 13, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants