Skip to content

test: exluding from airgap list of tests #38596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yatinappsmith merged 1 commit into from
Jan 13, 2025
Merged

test: exluding from airgap list of tests #38596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 52 additions & 48 deletions app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/VerifyImport_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,55 +11,59 @@ import EditorNavigation, {
} from "../../../../support/Pages/EditorNavigation";
import ReconnectLocators from "../../../../locators/ReconnectLocators";

describe("Tests Import option for normal apps at app level", {}, () => {
before(() => {
gitSync.CreateNConnectToGit();
});
describe(
"Tests Import option for normal apps at app level",
{ tags: ["@tag.excludeForAirgap"] },
() => {
before(() => {
gitSync.CreateNConnectToGit();
});

it("1. Verify Import Option at app level", () => {
let Datasource = [
"AWSLambda",
"Airtable",
"GSheets_RWDSelected",
"GSheets_RWDAll",
"Hubspot",
"gsheet",
"Twilio",
"Dynamo",
"ElasticSearch",
"Firestore",
"Movies",
"Mongo",
"Oracle",
"Redshift",
"PostGreSQL",
"SMTP",
"Snowflake",
"S3",
"Oauth2.0",
"Pixabay",
"OpenAI",
];
AppSidebar.navigate(AppSidebarButton.Settings);
agHelper.GetNClick(appSettings.locators._importHeader);
agHelper.AssertElementEnabledDisabled(appSettings.locators._importBtn);
it("1. Verify Import Option at app level", () => {
let Datasource = [
"AWSLambda",
"Airtable",
"GSheets_RWDSelected",
"GSheets_RWDAll",
"Hubspot",
"gsheet",
"Twilio",
"Dynamo",
"ElasticSearch",
"Firestore",
"Movies",
"Mongo",
"Oracle",
"Redshift",
"PostGreSQL",
"SMTP",
"Snowflake",
"S3",
"Oauth2.0",
"Pixabay",
"OpenAI",
];
AppSidebar.navigate(AppSidebarButton.Settings);
agHelper.GetNClick(appSettings.locators._importHeader);
agHelper.AssertElementEnabledDisabled(appSettings.locators._importBtn);
Comment on lines +47 to +48
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Combine assertions and use data- attributes.*

Consider the following improvements:

  1. Use data-* attributes for selectors instead of class-based locators
  2. Combine the import button assertions into a single expect statement

Example:

cy.get('[data-cy=import-button]')
  .should('exist')
  .and('be.visible')
  .and('be.enabled');

Also applies to: 53-58


homePage.NavigateToHome();
homePage.CreateNewApplication();
AppSidebar.navigate(AppSidebarButton.Settings);
agHelper.GetNClick(appSettings.locators._importHeader);
agHelper.AssertElementEnabledDisabled(
appSettings.locators._importBtn,
0,
false,
);
agHelper.GetNClick(appSettings.locators._importBtn);
homePage.ImportApp("TryToCoverMore.json", "", true);
agHelper.GetNClick(ReconnectLocators.SkipToAppBtn);
homePage.NavigateToHome();
homePage.CreateNewApplication();
AppSidebar.navigate(AppSidebarButton.Settings);
agHelper.GetNClick(appSettings.locators._importHeader);
agHelper.AssertElementEnabledDisabled(
appSettings.locators._importBtn,
0,
false,
);
agHelper.GetNClick(appSettings.locators._importBtn);
homePage.ImportApp("TryToCoverMore.json", "", true);
agHelper.GetNClick(ReconnectLocators.SkipToAppBtn);

AppSidebar.navigate(AppSidebarButton.Data);
Datasource.forEach((ds) => {
agHelper.GetNAssertContains(locators._listItemTitle, ds);
AppSidebar.navigate(AppSidebarButton.Data);
Datasource.forEach((ds) => {
agHelper.GetNAssertContains(locators._listItemTitle, ds);
});
});
});
});
},
);