DNM: checking failure

[sagar-qa007]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Warning

Tests have not run on the HEAD 54451fc yet

---

Mon, 13 Jan 2025 05:20:30 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Tests
  • Updated the limited test configuration to focus on Application URL tests instead of Anvil Widgets tests.

[coderabbitai]

Walkthrough

This pull request involves a modification to the app/client/cypress/limited-tests.txt file, specifically changing the test path focus. The previous test path for Anvil Widgets has been replaced with a new path targeting Application URL tests. This adjustment alters the scope of limited tests to be executed, shifting the testing focus from Anvil Widgets to Application URL functionality.

Changes

File	Change Summary
app/client/cypress/limited-tests.txt	Replaced test path from Anvil Widgets to Application URL tests

Possibly related PRs

• feat: Preliminary set of test cases and test utils for Anvil DnD and Space distribution. #33827: Modifications to Anvil widget test cases
• test: partial import export areas covered #37661: Updates to limited-tests.txt for partial import/export tests
• test: adding tests for custom lib #37901: Changes to test paths for a custom library test

Suggested Labels

skip-changelog, ok-to-test, Test

Suggested Reviewers

• ApekshaBhosale
• yatinappmath

Poem

In the realm of tests, a path shifts its way,
From Anvil's widgets to URLs' display,
A cypress journey, brief and bright,
Redirecting focus with testing might! 🧭🔍
Code's compass spins, a new test takes flight! 🚀

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cc3899 and 54451fc.

📒 Files selected for processing (1)

• app/client/cypress/limited-tests.txt (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/client/cypress/limited-tests.txt (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-build / client-build

🔇 Additional comments (2)

app/client/cypress/limited-tests.txt (2)

Line range hint 1-8: Consider adding more test paths for comprehensive failure checking.

Since this PR is titled "DNM: checking failure", you might want to include additional test paths to cover more failure scenarios.

---

5-5: LGTM! Test path follows the correct format.

The path format is correct and matches the Cypress test file structure.

Let's verify the test file exists and follows the coding guidelines:

✅ Verification successful

Test file exists and follows best practices

The cy.wait usage is correctly implemented with an intercept and no other anti-patterns were found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the test file exists and check for any guideline violations
echo "Verifying test file existence and content..."
rg -l "ApplicationURL_spec.js" app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/

echo "Checking for prohibited practices..."
# Check for cy.wait usage
rg "cy\.wait" "app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js"

# Check for cy.pause usage
rg "cy\.pause" "app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js"

# Check for agHelper.sleep usage
rg "agHelper\.sleep" "app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js"

# Check for it.only usage
rg "it\.only" "app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js"

Length of output: 742

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sagar-qa007]

/ci-test-limit-count run_count=30 update_snapshot=false

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12741137680.
Cypress dashboard
PR: #38595 .

[sagar-qa007]

/ci-test-limit-count run_count=30 update_snapshot=false

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12745129536.
Cypress dashboard
PR: #38595 .

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12745129536.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 120 Total Passed: 120 Total Failed: 0 Total Skipped: 0 *****************************

[sagar-qa007]

/ci-test-limit-count run_count=50 update_snapshot=false

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12808648887.
Cypress dashboard
PR: #38595 .

[sagar-qa007]

/ci-test-limit-count run_count=50 update_snapshot=false runId=12807676303

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12808678005.
Cypress dashboard
PR: #38595 .

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12808678005.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 200 Total Passed: 200 Total Failed: 0 Total Skipped: 0 *****************************