chore: CE split for git constants and AGF #38464
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,5 @@ | ||
| package com.appsmith.git.constants; | ||
|
|
||
| import com.appsmith.git.constants.ce.CommonConstantsCE; | ||
|
|
||
| public class CommonConstants extends CommonConstantsCE {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package com.appsmith.git.constants.ce; | ||
|
|
||
| public class CommonConstantsCE { | ||
| // This field will be useful when we migrate fields within JSON files (currently this will be useful for Git | ||
| // feature) | ||
| public static Integer fileFormatVersion = 5; | ||
| public static String FILE_FORMAT_VERSION = "fileFormatVersion"; | ||
| public static final String SERVER_SCHEMA_VERSION = "serverSchemaVersion"; | ||
| public static final String CLIENT_SCHEMA_VERSION = "clientSchemaVersion"; | ||
|
|
||
| public static final String CANVAS = "canvas"; | ||
|
|
||
| public static final String APPLICATION = "application"; | ||
| public static final String THEME = "theme"; | ||
| public static final String METADATA = "metadata"; | ||
| public static final String JSON_EXTENSION = ".json"; | ||
| public static final String JS_EXTENSION = ".js"; | ||
| public static final String TEXT_FILE_EXTENSION = ".txt"; | ||
| public static final String WIDGETS = "widgets"; | ||
| public static final String WIDGET_NAME = "widgetName"; | ||
| public static final String WIDGET_TYPE = "type"; | ||
| public static final String CHILDREN = "children"; | ||
|
|
||
| public static final String CANVAS_WIDGET = "CANVAS_WIDGET"; | ||
| public static final String MAIN_CONTAINER = "MainContainer"; | ||
| public static final String DELIMITER_POINT = "."; | ||
| public static final String DELIMITER_PATH = "/"; | ||
| public static final String DELIMITER_HYPHEN = "-"; | ||
| public static final String EMPTY_STRING = ""; | ||
| public static final String SEPARATOR_UNDERSCORE = "_"; | ||
| public static final String FILE_MIGRATION_MESSAGE = | ||
| "Some of the changes above are due to an improved file structure. You can safely commit them to your repository."; | ||
|
|
||
| public static final String TABS_WIDGET = "TABS_WIDGET"; | ||
|
|
||
| public static final String WIDGET_ID = "widgetId"; | ||
| public static final String PARENT_ID = "parentId"; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| package com.appsmith.server.helpers; | ||
|
|
||
| import com.appsmith.server.dtos.ArtifactExchangeJson; | ||
| import com.appsmith.server.helpers.ce.ArtifactGitFileUtilsCE; | ||
|
|
||
| public interface ArtifactGitFileUtils<T extends ArtifactExchangeJson> extends ArtifactGitFileUtilsCE<T> {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Ensure method return types match the new generic parameter.
This class now implements
ArtifactGitFileUtilsCE<ArtifactExchangeJson>, yet it still declarescreateArtifactReferenceObject()returningApplicationGitReference. Revisit and align the return types/methods to prevent confusion or type mismatches.