Skip to content

test: flaky check for published Spec #38427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NandanAnantharamu merged 3 commits into from
Jan 3, 2025
Merged

test: flaky check for published Spec #38427

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0569e3
updated limited run file
Dec 31, 2024
47fcf93
skipping tests due to an existing bug
Jan 2, 2025
a174b8a
reverted limited run file changes
Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/cypress/limited-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# To run only limited tests - give the spec names in below format:
cypress/e2e/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js
cypress/e2e/Regression/ClientSide/PublishedApps/PublishedModeToastToggle_Spec.ts

@coderabbitai coderabbitai Bot Dec 31, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Remove prohibited agHelper.Sleep() usage

The test implementation follows Cypress best practices except for one issue:

  • Line 89: _.agHelper.Sleep(2000) should be replaced with a proper wait condition using assertions or intercepts.
🔗 Analysis chain

LGTM! Verify the new test implementation.

The change follows the correct format for specifying limited tests.

Let's verify the new test file exists and follows the Cypress guidelines:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new test file exists and follows guidelines

# Check if the test file exists
fd "PublishedModeToastToggle_Spec.ts" app/client/cypress

# Check for prohibited practices
echo "Checking for prohibited practices..."
rg -i "cy\.wait|cy\.pause|agHelper\.sleep|it\.only|after\(|afterEach\(" "app/client/cypress/e2e/Regression/ClientSide/PublishedApps/PublishedModeToastToggle_Spec.ts" || echo "No prohibited practices found"

# Check selector usage
echo "Checking selector patterns..."
rg "\.btn\.submit|button\[type=submit\]|\$\('" "app/client/cypress/e2e/Regression/ClientSide/PublishedApps/PublishedModeToastToggle_Spec.ts" || echo "No prohibited selectors found"

Length of output: 710

Script:

#!/bin/bash
# Let's examine the test file content to verify test structure and patterns
cat "app/client/cypress/e2e/Regression/ClientSide/PublishedApps/PublishedModeToastToggle_Spec.ts"

Length of output: 3621

# For running all specs - uncomment below:
#cypress/e2e/**/**/*

Expand Down