Skip to content

chore: Adding host as a parameter for get home page workspaces API #38392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trishaanand merged 2 commits into from
Dec 27, 2024
Merged

chore: Adding host as a parameter for get home page workspaces API #38392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d37e8d
chore: Adding host as a parameter for get home page workspaces API
trishaanand Dec 27, 2024
481dcbc
Fixing compilation failures
trishaanand Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...psmith-server/src/main/java/com/appsmith/server/controllers/ce/WorkspaceControllerCE.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,10 @@ public Mono<ResponseDTO<Workspace>> deleteLogo(@PathVariable String workspaceId)

@JsonView(Views.Public.class)
@GetMapping("/home")
public Mono<ResponseDTO<List<Workspace>>> workspacesForHome() {
public Mono<ResponseDTO<List<Workspace>>> workspacesForHome(
@RequestHeader(name = "Host", required = false) String hostname) {

@abhvsn abhvsn Dec 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace this with x-appsmith-host to make it apparent that this is custom header?

@trishaanand trishaanand Dec 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a custom header.

return userWorkspaceService
.getUserWorkspacesByRecentlyUsedOrder()
.getUserWorkspacesByRecentlyUsedOrder(hostname)
.map(workspaces -> new ResponseDTO<>(HttpStatus.OK.value(), workspaces, null));
}
}
2 changes: 1 addition & 1 deletion ...appsmith-server/src/main/java/com/appsmith/server/services/ce/UserWorkspaceServiceCE.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ Mono<MemberInfoDTO> updatePermissionGroupForMember(

Boolean isLastAdminRoleEntity(PermissionGroup permissionGroup);

Mono<List<Workspace>> getUserWorkspacesByRecentlyUsedOrder();
Mono<List<Workspace>> getUserWorkspacesByRecentlyUsedOrder(String hostname);
}
2 changes: 1 addition & 1 deletion ...mith-server/src/main/java/com/appsmith/server/services/ce/UserWorkspaceServiceCEImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ public Boolean isLastAdminRoleEntity(PermissionGroup permissionGroup) {
* @return Mono of list of workspaces
*/
@Override
public Mono<List<Workspace>> getUserWorkspacesByRecentlyUsedOrder() {
public Mono<List<Workspace>> getUserWorkspacesByRecentlyUsedOrder(String hostname) {

Mono<List<String>> workspaceIdsMono = userDataService
.getForCurrentUser()
Expand Down