chore: Design changes for Editor tabs by hetunandu · Pull Request #38326 · appsmithorg/appsmith

hetunandu · 2024-12-23T13:02:42Z

Description

Update the UX of editor tabs

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12515785103
Commit: 8a6f2fa
Cypress dashboard.
Tags: @tag.IDE
Spec:

Fri, 27 Dec 2024 12:36:15 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Style
- Updated border styling for the Tab component to enhance visual appearance.
- Introduced bold font-weight for active tab span elements.
- Adjusted image width in the IconContainer for improved icon presentation.

coderabbitai · 2024-12-23T13:02:50Z

Walkthrough

The pull request introduces styling modifications to the FileTab component in the styles.tsx file. The changes focus on enhancing the visual representation of tabs, specifically updating the active tab's border thickness to 3px and adding bold font styling. The modifications aim to improve the user interface's visual consistency and clarity for tab interactions.

Changes

File	Change Summary
`app/client/src/IDE/Components/FileTab/styles.tsx`	- Updated `Tab` component's `border-top` from 2px to 3px solid transparent - Added bold font weight for `span` in active tab - Modified `IconContainer` to set `img` width to 12px

Assessment against linked issues

Objective	Addressed	Explanation
Active tab should have bold font and border top of 3 px [#38375]	✅

Possibly related PRs

feat: New tab ui changes #33228: New tab UI changes potentially related to tab styling
fix: Tabs UI updates #33536: UI updates for Tabs component with border styling modifications
fix: Tab navigation issue in multi page apps #38272: Tab navigation issue that might intersect with visual styling changes

Suggested labels

Enhancement

Suggested reviewers

ankitakinger
sagar-qa007

Poem

Tabs dancing with style so bright,
Borders bold, a pixel's might!
From two to three, a subtle leap,
In code's canvas, design we keep.
UI magic, pixel perfect sight! 🎨✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hetunandu · 2024-12-23T13:02:58Z

/build-deploy-preview

github-actions · 2024-12-23T13:03:21Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12467254336.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 38326.
recreate: .

github-actions · 2024-12-23T13:16:05Z

Deploy-Preview-URL: https://ce-38326.dp.appsmith.com

hetunandu · 2024-12-26T06:37:01Z

/build-deploy-preview

github-actions · 2024-12-26T06:37:24Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12500659649.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 38326.
recreate: .

github-actions · 2024-12-26T06:51:41Z

Deploy-Preview-URL: https://ce-38326.dp.appsmith.com

alex-golovanov · 2024-12-26T10:15:38Z

app/client/src/IDE/Components/EditableName/useIsRenaming.ts


  const isEditingViaExternal = useSelector(getIsRenaming(id));

+  const isNew =


One thing to keep in mind is that isNew will not automatically update on history changes unless something else forces a re-render of this component. In other words it will not watch for route changes and will not update state by itself.

Disregard, if this is the desired behavior.

Removed this for now. Needs a relook

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/IDE/Components/FileTab/styles.tsx (1)

29-32: Good addition for emphasis on active tabs.

Applying a bold font weight to the span within .active nicely highlights the active tab. This helps users quickly spot which tab is selected.

You might want to consider a consistent text styling approach for all tab states, defining them in a single centralized style block or using theme variables.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0255bce and 8a6f2fa.

📒 Files selected for processing (1)

app/client/src/IDE/Components/FileTab/styles.tsx (2 hunks)

🔇 Additional comments (2)

app/client/src/IDE/Components/FileTab/styles.tsx (2)

21-21: Nice alignment with the new design.

Increasing the top border thickness from 2px to 3px can improve visual clarity for the active tab. This looks consistent with your design goals.

54-54: Consistent icon sizing.

Setting img { width: 12px } ensures a uniform icon size across your tabs. This helps maintain visual harmony in the UI.

ankitakinger · 2024-12-27T11:58:39Z

/build-deploy-preview skip-tests=true

github-actions · 2024-12-27T11:59:02Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12515760097.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38326.
recreate: .

github-actions · 2024-12-27T12:12:21Z

Deploy-Preview-URL: https://ce-38326.dp.appsmith.com

hetunandu added 2 commits December 23, 2024 18:31

Bold text of active tab

d7fb204

Enable rename for new items

fb386db

chore: Increase tab top border height

d9985d0

hetunandu changed the title ~~Chore: Design changes for Editor tabs~~ chore: Design changes for Editor tabs Dec 26, 2024

github-actions bot added the Task A simple Todo label Dec 26, 2024

hetunandu requested a review from alex-golovanov December 26, 2024 08:24

hetunandu added the ok-to-test Required label for CI label Dec 26, 2024

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog IDE Pod Issues that new developers face while exploring the IDE IDE tabs query and js tabs labels Dec 26, 2024

alex-golovanov reviewed Dec 26, 2024

View reviewed changes

hetunandu added 2 commits December 27, 2024 10:36

Merge branch 'release' into chore/editor-tabs-design

806bdbe

fix: Fix Create JS method

b279053

github-actions bot added the IDE Product Issues related to the IDE Product label Dec 27, 2024

hetunandu added 3 commits December 27, 2024 16:20

Merge branch 'release' into chore/editor-tabs-design

8fa3eee

chore: Remove renaming via url

ce01690

Discard changes to app/client/cypress/support/Pages/JSEditor.ts

8a6f2fa

hetunandu marked this pull request as ready for review December 27, 2024 11:52

hetunandu requested review from alex-golovanov and ankitakinger December 27, 2024 11:53

coderabbitai bot reviewed Dec 27, 2024

View reviewed changes

ankitakinger approved these changes Dec 27, 2024

View reviewed changes

hetunandu added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Dec 27, 2024

hetunandu merged commit ec51cf0 into release Dec 27, 2024

hetunandu deleted the chore/editor-tabs-design branch December 27, 2024 13:57

github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025

chore: Design changes for Editor tabs (appsmithorg#38326)

563519f


		const isEditingViaExternal = useSelector(getIsRenaming(id));

		const isNew =

Conversation

hetunandu commented Dec 23, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

hetunandu commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

github-actions bot commented Dec 23, 2024

Uh oh!

hetunandu commented Dec 26, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

alex-golovanov Dec 26, 2024

Choose a reason for hiding this comment

Uh oh!

hetunandu Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

ankitakinger commented Dec 27, 2024

Uh oh!

github-actions bot commented Dec 27, 2024

Uh oh!

github-actions bot commented Dec 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hetunandu commented Dec 23, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Dec 23, 2024 •

edited

Loading