Skip to content

fix: Fix for locator for AddWidgetTableAndBind_spec test case#38313

Merged
sagar-qa007 merged 1 commit intoreleasefrom
fix/widgetcasefailurefortbp
Dec 23, 2024
Merged

fix: Fix for locator for AddWidgetTableAndBind_spec test case#38313
sagar-qa007 merged 1 commit intoreleasefrom
fix/widgetcasefailurefortbp

Conversation

@sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Dec 23, 2024

Description

Found minor locator failure

Fixes # https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38314

Automation

/ok-to-test tags="@tag.Datasource,@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12465389478
Commit: 9cf2fbe
Cypress dashboard.
Tags: @tag.Datasource,@tag.Sanity
Spec:


Mon, 23 Dec 2024 13:19:11 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes
    • Updated the locator for the query response to ensure accurate referencing of the second row in the table, improving the application's interaction with query results.

@sagar-qa007 sagar-qa007 requested review from hetunandu and removed request for ApekshaBhosale December 23, 2024 10:33
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2024

Walkthrough

This pull request involves a minor modification to an XPath locator in the QueryEditor.json file within the Cypress test suite. The change adjusts the target row for a query response locator from the third row to the second row, which could impact how specific elements are selected during test automation.

Changes

File Change Summary
app/client/cypress/locators/QueryEditor.json Updated XPath selector for queryResponse from third row [3] to second row [2]

Suggested labels

Bug, ok-to-test, skip-changelog

Suggested reviewers

  • ApekshaBhosale
  • NandanAnantharamu

Possibly related PRs

Poem

Locators dance, rows shift and sway
XPath selectors find their way
From third to second, a subtle slide
Testing's precision, we can't hide! 🕵️‍♀️🔍


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Dec 23, 2024
@github-actions github-actions bot added the Bug Something isn't working label Dec 23, 2024
@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=3 update_snapshot=true specs_to_run=cypress/e2e/Regression/ServerSide/QueryPane/AddWidgetTableAndBind_spec.js

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12465401100.
Cypress dashboard
PR: #38313 with spec: cypress/e2e/Regression/ServerSide/QueryPane/AddWidgetTableAndBind_spec.js .

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcb27d2 and 9cf2fbe.

📒 Files selected for processing (1)
  • app/client/cypress/locators/QueryEditor.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/locators/QueryEditor.json (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

  • Follow best practices for Cypress code and e2e automation.
  • Avoid using cy.wait in code.
  • Avoid using cy.pause in code.
  • Avoid using agHelper.sleep().
  • Use locator variables for locators and do not use plain strings.
  • Use data-* attributes for selectors.
  • Avoid Xpaths, Attributes and CSS path.
  • Avoid selectors like .btn.submit or button[type=submit].
  • Perform logins via API with LoginFromAPI.
  • Perform logout via API with LogOutviaAPI.
  • Perform signup via API with SignupFromAPI.
  • Avoid using it.only.
  • Avoid using after and aftereach in test cases.
  • Use multiple assertions for expect statements.
  • Avoid using strings for assertions.
  • Do not use duplicate filenames even with different paths.
  • Avoid using agHelper.Sleep, this.Sleep in any file in code.

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12465401100.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 9 Total Passed: 9 Total Failed: 0 Total Skipped: 0 *****************************

@sagar-qa007 sagar-qa007 merged commit 2eac193 into release Dec 23, 2024
@sagar-qa007 sagar-qa007 deleted the fix/widgetcasefailurefortbp branch December 23, 2024 13:20
NandanAnantharamu pushed a commit that referenced this pull request Dec 27, 2024
## Description
Found minor locator failure


Fixes #
https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38314

## Automation

/ok-to-test tags="@tag.Datasource,@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12465389478>
> Commit: 9cf2fbe
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12465389478&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource,@tag.Sanity`
> Spec:
> <hr>Mon, 23 Dec 2024 13:19:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the locator for the query response to ensure accurate
referencing of the second row in the table, improving the application's
interaction with query results.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025
…thorg#38313)

## Description
Found minor locator failure


Fixes #
https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38314

## Automation

/ok-to-test tags="@tag.Datasource,@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12465389478>
> Commit: 9cf2fbe
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12465389478&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource,@tag.Sanity`
> Spec:
> <hr>Mon, 23 Dec 2024 13:19:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the locator for the query response to ensure accurate
referencing of the second row in the table, improving the application's
interaction with query results.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working ok-to-test Required label for CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants