Skip to content

chore: fix text area ui bug #38282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsartisan merged 1 commit into from
Dec 20, 2024
Merged

chore: fix text area ui bug #38282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions app/client/packages/design-system/widgets/src/components/Input/src/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

.inputGroup {
max-inline-size: 100%;
padding-block: var(--inner-spacing-1);
padding-inline: var(--inner-spacing-2);
gap: var(--inner-spacing-1);
border: 0;
border-radius: var(--border-radius-elevation-3);
Expand All @@ -26,6 +24,17 @@
background-color: transparent;
flex: 1;
padding: 0;
padding-block: var(--inner-spacing-1);
padding-inline: var(--inner-spacing-2);
box-sizing: content-box;
}

.inputGroup:has([data-input-prefix]) .input {
padding-inline-start: 0;
}

.inputGroup:has([data-input-suffix]) .input {
padding-inline-end: 0;
}

.input:is(textarea) {
Expand All @@ -50,6 +59,14 @@
* SUFFIX and PREFIX
* ----------------------------------------------------------------------------
*/
.inputGroup [data-input-prefix] {
margin-inline-start: var(--inner-spacing-2);
}

.inputGroup [data-input-suffix] {
margin-inline-end: var(--inner-spacing-2);
}

.inputGroup :is([data-input-suffix], [data-input-prefix]) button {
border-radius: calc(
var(--border-radius-elevation-3) - var(--inner-spacing-1)
Expand All @@ -60,7 +77,6 @@
display: flex;
justify-content: center;
align-items: center;
height: 0;
}

/**
Expand Down Expand Up @@ -88,9 +104,12 @@
* READONLY
* ----------------------------------------------------------------------------
*/
.input[data-readonly] {
.inputGroup:has(> .input[data-readonly]) {
background-color: transparent;
box-shadow: none;
}

.inputGroup input[data-readonly] {
padding-inline: 0;
}

Expand Down Expand Up @@ -164,17 +183,17 @@
* SIZE
* ----------------------------------------------------------------------------
*/
.inputGroup:has(> .input[data-size="small"]) {
block-size: calc(
var(--body-line-height) + var(--body-margin-start) + var(--body-margin-end) +
var(--inner-spacing-2) * 2
);
.inputGroup .input {
block-size: var(--body-line-height);
}

.inputGroup:has(> .input[data-size="large"]) {
.inputGroup .input[data-size="small"] {
block-size: calc(
var(--body-line-height) + var(--body-margin-start) + var(--body-margin-end)
);
padding-block: var(--inner-spacing-3);
padding-inline: var(--inner-spacing-3);
padding: var(--inner-spacing-2);
}

.inputGroup .input[data-size="large"] {
padding: var(--inner-spacing-3);
}
8 changes: 2 additions & 6 deletions app/client/packages/design-system/widgets/src/components/TextArea/src/TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,12 @@ export function TextArea(props: TextAreaProps) {

input.style.height = `${
// subtract comptued padding and border to get the actual content height
input.scrollHeight -
paddingTop -
paddingBottom +
// Also, adding 1px to fix a bug in browser where there is a scrolllbar on certain heights
1
input.scrollHeight - paddingTop - paddingBottom
}px`;
input.style.overflow = prevOverflow;
input.style.alignSelf = prevAlignment;
}
}, [inputRef.current, props.height]);
}, [props.height]);

useLayoutEffect(() => {
if (inputRef.current) {
Expand Down