20/12 Daily Promotion by RakshaKShetty · Pull Request #38273 · appsmithorg/appsmith

RakshaKShetty · 2024-12-20T07:07:16Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Warning

Tests have not run on the HEAD d1cff32 yet

Fri, 20 Dec 2024 07:08:13 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

## Description As part of transaction support in PG, we are moving from using the jpa methods for database operations. This PR is refactoring the code to use custom repository class for DatasourceStorageRepository from the default CrudRepository. ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12406578294> > Commit: c7efa63 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12406578294&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Thu, 19 Dec 2024 05:27:22 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced new methods for retrieving and counting `NewAction` entities based on application ID and IDs collection. - **Bug Fixes** - Removed outdated methods from the `NewActionRepositoryCE` interface to streamline functionality. - **Refactor** - Enhanced repository capabilities for managing `NewAction` entities while maintaining backward compatibility.

## Description Updates a few visual elements for better Navigational experience using the Segmented Controls Fixes #37881 ## Automation /ok-to-test tags="@tag.IDE, @tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12409098657> > Commit: a94e072 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12409098657&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE, @tag.Sanity` > Spec: > <hr>Thu, 19 Dec 2024 12:51:29 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Added `testId` property to sidebar buttons for enhanced testing capabilities. - Updated button titles from "Data" to "Datasources" for clarity. - Introduced `BottomButtons` configuration for sidebar buttons based on data source availability. - **Bug Fixes** - Improved visual distinction of selected segments in the Segmented Control. - **Style** - Enhanced styling for sidebar buttons and segments, including hover effects and separators. - **Tests** - Added tests to verify rendering of sidebar buttons with the correct test IDs.

…d new integrations (#38110)

## Description Converted the lookup the in isNewEntity to use a Set, this has reduced the cost of webworker scripting by about 5%. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12415891373> > Commit: 5dfc7a0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12415891373&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 19 Dec 2024 16:55:57 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Enhanced evaluation logic for newly created entities. - Improved error handling for dynamic bindings during evaluations. - **Bug Fixes** - Refined error tracking for property evaluations. - **Documentation** - Minor updates to comments and formatting for clarity.

coderabbitai · 2024-12-20T07:07:23Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

## Description Adding workflow for updating snapshot with github CI. Fixes #[`36419` ](#36419) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12426577557> > Commit: 2660c07 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12426577557&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 20 Dec 2024 07:02:16 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Enhanced CI workflow with new input parameters for snapshot updates and spec execution. - Added steps for uploading existing and new snapshot data during Cypress tests. - **Bug Fixes** - Improved artifact management and error handling in the CI process. - **Documentation** - Added comments for better understanding of workflow logic and input parameters. - **Refactor** - Streamlined job execution logic and conditional checks for test reruns.

laveena-en

Approved

AnaghHegde and others added 6 commits December 19, 2024 15:24

fix: Enhance SelectWidget label and value handling logic (#38254)

9705048

chore: Analytics util refactor (#38089)

4a91204

chore: added premium tags datasources for knowing users request to ad…

e22dbd1

…d new integrations (#38110)

RakshaKShetty requested a review from laveena-en December 20, 2024 07:07

RakshaKShetty requested review from a team, ApekshaBhosale, KelvinOm, ayushpahwa, nidhi-nair, sagar-qa007 and sondermanish as code owners December 20, 2024 07:07

sagar-qa007 requested a review from sharat87 as a code owner December 20, 2024 07:07

laveena-en approved these changes Dec 20, 2024

View reviewed changes

btsgh merged commit b4b40d4 into master Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

20/12 Daily Promotion#38273

20/12 Daily Promotion#38273
btsgh merged 7 commits intomasterfrom
release

RakshaKShetty commented Dec 20, 2024 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Dec 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

laveena-en left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

RakshaKShetty commented Dec 20, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Dec 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

laveena-en left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

RakshaKShetty commented Dec 20, 2024 •

edited by github-actions bot

Loading