chore: Add code-split for injecting JIT pull in app CI/CD

[subrata71]

Description

EE counterpart PR: https://github.com/appsmithorg/appsmith-ee/pull/5780

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12471975301
Commit: f0a7b1e
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Mon, 23 Dec 2024 20:06:14 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Introduced a method for validating and publishing artifacts before discarding changes.
  • Added functionality to commit artifacts to a Git repository with customizable commit messages.
  • Expanded interface capabilities with a new method for validating artifacts.

• Bug Fixes

  • Enhanced error handling in the discard changes process to improve resource management during failures.

[coderabbitai]

Walkthrough

The pull request introduces a new method validateAndPublishArtifact in the CommonGitServiceCEImpl class, enhancing the validation and publishing logic for artifacts. The discardChanges method is modified to utilize this new method, improving code modularity and error handling. Additionally, a new commitArtifact method is added in the GitFileSystemTestHelper class, allowing for customizable commit messages when committing artifacts to a Git repository.

Changes

File	Change Summary
app/server/appsmith-server/src/main/java/.../CommonGitServiceCEImpl.java	Added validateAndPublishArtifact method; modified discardChanges to use this method and improved error handling.
app/server/appsmith-server/src/main/java/.../GitApplicationHelperCEImpl.java	Added validateAndPublishArtifact method to implement validation before publishing artifacts.
app/server/appsmith-server/src/main/java/.../GitArtifactHelperCE.java	Added validateAndPublishArtifact method to the interface for artifact validation and publishing.
app/server/appsmith-server/src/test/java/.../GitFileSystemTestHelper.java	Added commitArtifact method for committing artifacts with customizable commit messages; modified setupGitRepository to use this new method.

Possibly related PRs

• fix: added edge case fixes for consolidated api and publishing #37399: Modifications to CommonGitServiceCEImpl class, relevant to the discard changes.
• chore: Added changes for discard #38152: New discardChanges method in CentralGitServiceCEImpl, aligning with discard functionality.
• chore: pr for delete references #38210: Addition of deleteGitReference method in CentralGitServiceCE, related to managing Git references.
• test: Git integration tests #38237: Focus on Git integration tests, likely including testing for the discard functionality introduced in the main PR.

Suggested labels

Git Product, Enhancement, Task

Suggested reviewers

• nidhi-nair
• sondermanish

Poem

🌿 In the realm of Git, changes unfold,
A method for validation, a story retold.
Artifacts commit with a message so bright,
Modularity shines, bringing code to new heights!
Embrace the refactor, let clarity steer,
In the dance of development, we cheer! 🚀

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba0fd8b and f0a7b1e.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/git/common/CommonGitServiceCEImpl.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/git/common/CommonGitServiceCEImpl.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/server/appsmith-server/src/main/java/com/appsmith/server/applications/git/GitApplicationHelperCEImpl.java (1)

325-329: No evident validation logic
The current implementation of "validateAndPublishArtifact" simply delegates to "publishArtifact". Evaluate whether validation steps should be added or if the method name should be changed to better reflect its actual behavior.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f64446 and ba0fd8b.

📒 Files selected for processing (3)

• app/server/appsmith-server/src/main/java/com/appsmith/server/applications/git/GitApplicationHelperCEImpl.java (1 hunks)
• app/server/appsmith-server/src/main/java/com/appsmith/server/git/common/CommonGitServiceCEImpl.java (2 hunks)
• app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/GitArtifactHelperCE.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/git/common/CommonGitServiceCEImpl.java

🔇 Additional comments (1)

app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/GitArtifactHelperCE.java (1)

71-72: Question the purpose of validation
The method name suggests the presence of inline validation logic, but the interface does not specify the nature or scope of any checks. Consider clarifying whether additional logic is intended or if you plan a future implementation.