chore: Fix chrome version to 129 #38183
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,10 +138,14 @@ jobs: | |
| ./cypress/setup-test-ci.sh | ||
|
|
||
| - uses: browser-actions/setup-chrome@latest | ||
| id: setup-chrome | ||
| with: | ||
| chrome-version: 129 | ||
|
Contributor
There was a problem hiding this comment. 💡 Codebase verification Chrome version 129 is too far ahead of current stable releases The project uses Cypress 13.13.0 for testing, and Chrome 129 is not yet released (current stable is 120). Using unreleased browser versions in CI can lead to instability.
🔗 Analysis chainVerify Chrome version compatibility with test suite The change to Chrome version 129 should be validated against the test suite requirements and browser compatibility matrix. Consider implementing browser version compatibility checks in the test suite to prevent issues with future version updates. Let me check the specific browser version requirements in these files. Let me check the Cypress configuration to understand browser testing requirements. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check Chrome version compatibility with test suite
# Look for any browser version specific code or configurations
rg -g '*.{ts,js,json}' -l 'chrome.*version|browser.*version' app/client/
Length of output: 261 Script: #!/bin/bash
# Check the content of files for Chrome version references
rg -g '*.{ts,js,json}' 'chrome.*version|browser.*version' app/client/test/factories/MockPluginsState.ts
rg -g '*.{ts,js,json}' 'chrome.*version|browser.*version' app/client/cypress/fixtures/CommunityIssuesExport.json
# Check package.json for any browser dependencies
rg -g 'package.json' '"(cypress|playwright|puppeteer|selenium)"' .
# Check for any browser configuration in Cypress
fd -g 'cypress.config.*' .
Length of output: 66731 Script: #!/bin/bash
# Check Cypress configuration and browser settings
fd -t f -e json -e js cypress.config
fd -t f package.json -x cat {} \; | grep -A 5 -B 5 '"cypress":'
Length of output: 520 |
||
| install-chromedriver: true | ||
| install-dependencies: true | ||
| - run: | | ||
| echo "BROWSER_PATH=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV | ||
| ${{ steps.setup-chrome.outputs.chrome-path }} --version | ||
|
|
||
| - name: Save Git values | ||
| # pass env variables from this step to other steps | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -231,10 +231,14 @@ jobs: | |
| ./cypress/setup-test-ci.sh | ||
|
|
||
| - uses: browser-actions/setup-chrome@latest | ||
| id: setup-chrome | ||
| with: | ||
| chrome-version: 129 | ||
| install-chromedriver: true | ||
| install-dependencies: true | ||
| - run: | | ||
| echo "BROWSER_PATH=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV | ||
| ${{ steps.setup-chrome.outputs.chrome-path }} --version | ||
|
|
||
| - name: Save Git values | ||
| # pass env variables from this step to other steps | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -220,12 +220,16 @@ jobs: | |
| cd app/client | ||
| chmod a+x ./cypress/setup-test-ci.sh | ||
| ./cypress/setup-test-ci.sh | ||
| - uses: browser-actions/setup-chrome@latest | ||
| id: setup-chrome | ||
| with: | ||
| chrome-version: 129 | ||
| install-chromedriver: true | ||
| install-dependencies: true | ||
| - run: | | ||
| echo "BROWSER_PATH=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV | ||
| ${{ steps.setup-chrome.outputs.chrome-path }} --version | ||
|
|
||
| - name: Save Git values | ||
| # pass env variables from this step to other steps | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch with PR objective
The container specification uses Chrome 130, but the PR objective is to fix the Chrome version to 129. This inconsistency could lead to test reliability issues.
📝 Committable suggestion