Skip to content

chore: Fix chrome version to 129 #38183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yatinappsmith merged 22 commits into from
Dec 17, 2024
Merged

chore: Fix chrome version to 129 #38183

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
de463ba
Fix chrome version to 129
sagar-qa007 Dec 16, 2024
675b2d8
Updated to 130
sagar-qa007 Dec 16, 2024
5b9da46
Update version
sagar-qa007 Dec 16, 2024
580ecfd
Install driver as well
sagar-qa007 Dec 16, 2024
8c021cc
Update with new version
sagar-qa007 Dec 16, 2024
a7b6b81
Added dependency code
sagar-qa007 Dec 16, 2024
62b8944
Added timeout
sagar-qa007 Dec 17, 2024
7ee2433
Update with latest to verify process
sagar-qa007 Dec 17, 2024
8b373f9
Removed timeout
sagar-qa007 Dec 17, 2024
0f12909
Updated step
sagar-qa007 Dec 17, 2024
8b02cb3
Added hardcoded version
sagar-qa007 Dec 17, 2024
9c2aad1
added container
sagar-qa007 Dec 17, 2024
14f9a4b
Browser path setup
sagar-qa007 Dec 17, 2024
16086af
Update for browser path in limit
sagar-qa007 Dec 17, 2024
9371d79
limited test run
sagar-qa007 Dec 17, 2024
17c36dd
for ok to test change
sagar-qa007 Dec 17, 2024
002c6f9
Missed update
sagar-qa007 Dec 17, 2024
abb481d
Added cmd based browser
sagar-qa007 Dec 17, 2024
0e934ef
Download with new url
sagar-qa007 Dec 17, 2024
62ecc60
removed existing chrome
sagar-qa007 Dec 17, 2024
74d2c06
Final update with manually install browser
sagar-qa007 Dec 17, 2024
cc4ac10
Remove file
sagar-qa007 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-custom-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 130
- run: |
echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-hosted.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 130
- run: |
echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-limited-with-count.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 130

@coderabbitai coderabbitai Bot Dec 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Chrome version (130) doesn't match PR objective (129)

The PR objective states that Chrome version should be fixed to 129, but this line sets it to 130.

Apply this change to align with PR objective:

-          chrome-version: 130
+          chrome-version: 129
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
chrome-version: 130
chrome-version: 129

- run: |
echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-limited.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 130

@coderabbitai coderabbitai Bot Dec 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Chrome version (130) doesn't match PR objective (129)

The PR objective states that Chrome version should be fixed to 129, but this line sets it to 130.

Apply this change to align with PR objective:

-          chrome-version: 130
+          chrome-version: 129
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
chrome-version: 130
chrome-version: 129

- run: |
echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down