12/12 Daily Promotion by kamakshibhat-appsmith · Pull Request #38124 · appsmithorg/appsmith

kamakshibhat-appsmith · 2024-12-12T08:25:08Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

…mponent (#38096) ## Description rowGap and colGap was not accepting standard `spaces` values in Flex and Grid component. This PR fix that issue. Fixes #38097 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12273259261> > Commit: 16b48de > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12273259261&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 11 Dec 2024 10:01:27 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Introduced new CSS properties `rowGap` and `columnGap` for enhanced grid layout management within the design system.

…38033) ## Description Changed the klona strategy of evalActionBindings and parsed values within evaluateTree to use klonaJSON instead of klona. Seeing a 10-20% reduction in webworker scripting and a 4 second drop in LCP within a windows machine. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/12275133735> > Commit: dbe08f9 > Workflow: `PR Automation test suite` > Tags: `@tag.All` > Spec: `` > <hr>Wed, 11 Dec 2024 11:10:47 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Enhanced error handling during data evaluation, providing better context for debugging. - Improved logic for evaluating dynamic properties within the data tree. - **Bug Fixes** - Addressed issues with data cloning methods to ensure more reliable data handling. - **Refactor** - Updated method signatures for improved clarity and consistency across the evaluation processes.

## Description Updating the logic for datasource selector to fox the client build failure on prod Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results  > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/12277105493> > Commit: 507ed6f > Workflow: `PR Automation test suite` > Tags: `@tag.Datasource` > Spec: `` > <hr>Wed, 11 Dec 2024 13:13:25 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Enhanced `Datasource` component to support plugin data. - `DatasourceInfo`, `DatasourceTables`, and `DatasourceSelector` components now accept a `plugin` prop, improving their functionality and flexibility. - **Bug Fixes** - No functional changes, but improved handling of plugin data integration. - **Documentation** - Updated component interfaces to reflect new `plugin` prop.

## Description Slack thread: https://theappsmith.slack.com/archives/C04GRCN4CS3/p1733907474929399 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12277298947> > Commit: 71ba98b > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12277298947&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 11 Dec 2024 15:39:23 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Enhanced error handling for dynamic bindings by validating empty or null values. - **Bug Fixes** - Improved test coverage for handling null binding values in dynamic bindings. - **Tests** - Added a new test for verifying behavior with null binding values. - Updated existing tests to ensure they accurately reflect the expected outcomes.

This is unused and very old functionality that we don't need anymore. ## Automation /test sanity ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Enhanced observability features with new configurations for metrics and tracing. - **Bug Fixes** - Removed the welcome email feature toggle, simplifying email configuration. - **Chores** - Updated application properties to reflect changes in email handling and observability settings.

## Description This pull request introduces a new utility function `filterEntityGroupsBySearchTerm` to replace the existing `fuzzySearchInObjectItems` function. Type inference is significantly improved. Additionally, some renaming was done to convey true meaning and improve readability. Fixes [#37769](#37769) ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12277260297> > Commit: 153de75 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12277260297&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 11 Dec 2024 13:55:20 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced a new filtering functionality for entity groups based on search terms. - Added a test suite to validate the new filtering function across various scenarios. - **Bug Fixes** - Updated components to use the new filtering method, improving search result accuracy. - **Chores** - Removed obsolete fuzzy search functionality and associated tests to streamline the codebase. - **Refactor** - Renamed variables for clarity and consistency throughout the application.

coderabbitai · 2024-12-12T08:25:17Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

laveena-en

approved

github-actions · 2024-12-12T08:50:08Z

Failed server tests

com.appsmith.server.refactors.ce.RefactoringServiceCETest#testRefactorCollection_withModifiedName_ignoresName

albinAppsmith and others added 7 commits December 11, 2024 15:31

fixing the client build failure on prod

507ed6f

kamakshibhat-appsmith requested a review from laveena-en December 12, 2024 08:25

kamakshibhat-appsmith requested a review from ApekshaBhosale as a code owner December 12, 2024 08:25

laveena-en approved these changes Dec 12, 2024

View reviewed changes

btsgh merged commit 6689edd into master Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

12/12 Daily Promotion #38124

12/12 Daily Promotion #38124
btsgh merged 7 commits intomasterfrom
release

kamakshibhat-appsmith commented Dec 12, 2024

Uh oh!

coderabbitai bot commented Dec 12, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

laveena-en left a comment

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

kamakshibhat-appsmith commented Dec 12, 2024

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Dec 12, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

laveena-en left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 12, 2024

Failed server tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants