fix: fixing usage pulse for anon user (#37940)#37952
Conversation
## Description - For usage pulse we need pageId - URL contains basePageId - basePageId needs to be converted to pageId - The conversion needs application data to be populated into redux - The PR adds a wait for application to initialise first before sending the usage pulse Fixes [37904](#37904) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12157463790> > Commit: b4c4df1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12157463790&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 04 Dec 2024 11:40:43 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced user navigation tracking with improved handling of route changes. - Introduced a new function for managing user activity tracking, improving clarity and control flow. - **Bug Fixes** - Improved error handling during route changes to ensure proper logging. - **Refactor** - Restructured user-related sagas for better organization and separation of concerns. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
Fixes 37904
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12173569202
Commit: 1edecf1
Cypress dashboard.
Tags:
@tag.AllSpec:
Thu, 05 Dec 2024 06:57:25 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Enhanced user navigation tracking with improved handling of route changes.
Introduced a new function for managing user activity tracking, improving clarity and control flow.
Bug Fixes
Improved error handling during route changes to ensure proper logging.
Refactor
Restructured user-related sagas for better organization and separation of concerns.