Skip to content

fix: Fix for the test case #37936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sagar-qa007 merged 5 commits into from
Dec 6, 2024
Merged

fix: Fix for the test case #37936

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa1bddb
Fix for the test case
sagar-qa007 Dec 4, 2024
b061c1f
added more timeout
sagar-qa007 Dec 4, 2024
11de141
Increase timeout
sagar-qa007 Dec 4, 2024
751789d
New update
sagar-qa007 Dec 4, 2024
d71af4c
remvoed the file
sagar-qa007 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/client/cypress/e2e/Regression/ClientSide/BugTests/DS_Bug26941_Spec.ts
View file
Open in desktop
Copy link
Contributor

@yatinappsmith yatinappsmith Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising the wait will resulting in making the test flaky after few days.

Copy link
Contributor Author

@sagar-qa007 sagar-qa007 Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wait is not a hardcoded sleep; it is the timeout for the API call to respond. Typically, I observe successful responses within 1 second, but for better stability, I have set it to 2 seconds. If the response is received within 1 second, the test will pass without delay.

Maintaining this timeout avoids the need for adding retries, which could mask potential bugs. Introducing retries increases the risk of missing errors and reduces the accuracy of our tests.

Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe(
dataManager.dsValues[dataManager.defaultEnviorment].mockApiUrl
}123`;
apiPage.CreateAndFillApi(randomApi);
apiPage.RunAPI(false, 20, {
apiPage.RunAPI(false, 2000, {
expectedPath: "response.body.data.body.data.isExecutionSuccess",
expectedRes: false,
});
Expand All @@ -24,7 +24,7 @@ describe(
);

apiPage.EnterHeader(">", "");
apiPage.RunAPI(false, 20, {
apiPage.RunAPI(false, 2000, {
expectedPath: "response.body.data.body.data.isExecutionSuccess",
expectedRes: false,
});
Expand All @@ -37,7 +37,7 @@ describe(
});

apiPage.EnterHeader("", "");
apiPage.RunAPI(false, 20, {
apiPage.RunAPI(false, 2000, {
expectedPath: "response.body.data.body.data.isExecutionSuccess",
expectedRes: false,
});
Expand Down