Skip to content

fix: path fix for botton pane cypress#37911

Merged
albinAppsmith merged 2 commits intoreleasefrom
fix-folder-case-2
Dec 3, 2024
Merged

fix: path fix for botton pane cypress#37911
albinAppsmith merged 2 commits intoreleasefrom
fix-folder-case-2

Conversation

@albinAppsmith
Copy link
Contributor

@albinAppsmith albinAppsmith commented Dec 3, 2024

Description

This PR fixes the case conflict between IDE/BottomPane and IDE/Bottompane.

Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12135772830
Commit: 38cb59c
Cypress dashboard.
Tags: @tag.Sanity, @tag.Datasource
Spec:


Tue, 03 Dec 2024 09:30:39 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Updated import statements for the BottomPane component to BottomTabs across various test suites, enhancing component organization.
  • Bug Fixes

    • Improved test cases validating the binding of JavaScript objects to List widgets and ensuring accurate data reflection and pagination.
  • Chores

    • Removed outdated Response and BottomPane classes to streamline codebase and eliminate unused functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2024

Warning

Rate limit exceeded

@albinAppsmith has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 22 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5eebfca and 38cb59c.

Walkthrough

The pull request primarily involves updating import statements for the BottomPane component across various test files, changing the source from BottomPane to BottomTabs. Additionally, two files related to the BottomPane class have been deleted, which removes the associated functionality. The overall structure and logic of the test cases remain unchanged, focusing on validating the binding of JavaScript objects to widgets and various query functionalities.

Changes

File Path Change Summary
app/client/cypress/e2e/Regression/ClientSide/Binding/JSObjectToListWidget_Spec.ts Import updated from BottomPane to BottomTabs.
app/client/cypress/e2e/Regression/ClientSide/BugTests/Binding_Bug28287_Spec.ts Import updated from BottomPane to BottomTabs.
app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/OnLoadActions_Spec.ts Import updated from BottomPane to BottomTabs.
app/client/cypress/e2e/Regression/ServerSide/QueryPane/Querypane_Mongo_Spec.js Import updated from BottomPane to BottomTabs.
app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js Import updated from BottomPane to BottomTabs.
app/client/cypress/support/Pages/DataSources.ts Import updated from ./IDE/BottomPane to ./IDE/BottomTabs.
app/client/cypress/support/Pages/IDE/Bottompane/Response.ts File deleted; class Response removed.
app/client/cypress/support/Pages/IDE/Bottompane/index.ts File deleted; class BottomPane and its functionality removed.

Possibly related PRs

Suggested labels

Bug, ok-to-test, Test, Datasources, IDE Pod

Suggested reviewers

  • ApekshaBhosale
  • sagar-qa007

🌟 In the code's embrace, we find our way,
Changing BottomPane, to BottomTabs today.
Tests still run, with logic so clear,
Validating bindings, with no hint of fear.
Old classes gone, but the spirit remains,
In the world of code, we dance through the chains! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@albinAppsmith albinAppsmith requested review from hetunandu and removed request for ApekshaBhosale and sagar-qa007 December 3, 2024 08:25
@albinAppsmith albinAppsmith added the ok-to-test Required label for CI label Dec 3, 2024
@github-actions github-actions bot added the Bug Something isn't working label Dec 3, 2024
@albinAppsmith albinAppsmith merged commit 008a946 into release Dec 3, 2024
@albinAppsmith albinAppsmith deleted the fix-folder-case-2 branch December 3, 2024 09:34
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Dec 9, 2024
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12135772830>
> Commit: 38cb59c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12135772830&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource`
> Spec:
> <hr>Tue, 03 Dec 2024 09:30:39 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated import statements for the `BottomPane` component to
`BottomTabs` across various test suites, enhancing component
organization.
  
- **Bug Fixes**
- Improved test cases validating the binding of JavaScript objects to
List widgets and ensuring accurate data reflection and pagination.

- **Chores**
- Removed outdated `Response` and `BottomPane` classes to streamline
codebase and eliminate unused functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working ok-to-test Required label for CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants