02/12 Daily Promotion by btsgh · Pull Request #37866 · appsmithorg/appsmith

btsgh · 2024-12-02T06:18:55Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

## Description - Added structure for git modularisation Fixes #37434 #37435 ### No CI is required as the code is not exposed/ connected to existing code ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12080532772> > Commit: 0c251dd > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12080532772&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Fri, 29 Nov 2024 08:03:23 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Introduced Git handling capabilities, including committing changes, managing repositories, and handling branches. - Added support for managing Git user profiles and permissions related to artifact creation. - Enhanced artifact management with new methods for creating and retrieving artifacts based on workspace and repository details. - **Bug Fixes** - Improved error handling and validation for Git operations, ensuring robust interaction with remote repositories. - **Documentation** - Updated documentation to reflect new methods and functionalities related to Git operations and artifact management.

## Description - Updates the keys for redux store according to https://miro.com/app/board/uXjVL-Nij1k=/?share_link_id=2678396780 - Adds pending actions Fixes #36808 Fixes #36809 Fixes #36810 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12080417362> > Commit: 3d9de62 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12080417362&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Fri, 29 Nov 2024 08:00:47 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced new actions for managing branch operations (checkout, create, delete) and configurations (global, local). - Added actions for fetching and updating various Git-related data, including autocommit progress, merge status, and SSH keys. - New enumerations for Git artifact types and connection steps to enhance clarity and organization. - **Bug Fixes** - Improved error handling and loading state management across various actions. - **Documentation** - Enhanced type definitions and state structure for clearer understanding and usage. - **Refactor** - Updated state management structure to utilize a nested approach under `apiResponses`, improving consistency across actions.

Remove the websocket server on RTS. The RTS abbreviation has now completely lost significance. Let's now call it `rts`, in memory. 🙂 ## Automation /test sanity ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12078784104> > Commit: f858c99 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12078784104&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 29 Nov 2024 04:42:47 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Release Notes - **Bug Fixes** - Removed unnecessary socket-related dependencies and constants, streamlining the application. - **New Features** - Enhanced application performance by eliminating real-time communication features that were no longer necessary. - **Chores** - Cleaned up the codebase by removing outdated socket management files and constants, simplifying the overall architecture.

## Description Updated path for server-logs as file was not uploading Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Introduced a new input parameter `ted_tag` for specifying the TestEventDriver image tag in the CI workflow. - **Improvements** - Enhanced error handling with clearer messaging for database checks. - Improved caching mechanisms for better performance in CI tests. - Expanded logging and artifact upload processes for easier review of test results.

![CleanShot 2024-11-26 at 15 56 15](https://github.com/user-attachments/assets/d812f475-11e1-4750-9018-bdd39d5a5de3) /ok-to-test tags="@tag.Anvil"  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced the WDS Date Picker Widget, enhancing date selection capabilities within the UI. - Added configuration options for widget size, visibility, and autocomplete behavior. - Implemented comprehensive validation for date input, ensuring accurate user selections. - Expanded widget collection to include the new WDS Date Picker Widget. - Introduced new constants for date format options, facilitating diverse formatting choices. - Added support for a new "Date" input type, enhancing input widget configurability. - **Documentation** - Updated property pane configurations to include detailed settings for date format, validation, and event handling. - **Bug Fixes** - Improved handling of derived properties to ensure proper context during widget interactions. These updates collectively improve user experience and flexibility in date selection within the application.   > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12083004714> > Commit: b17348e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12083004714&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 29 Nov 2024 10:44:39 UTC  --------- Co-authored-by: Vadim Vaitenko <vadim@appsmith.com>

## Description In this PR, we update the code to send all the bindings to RTS together instead of calling it for each property binding. It was observed that the calls were earlier around 40k for the test application. This change leads to optimisation of performance for - updateLayout call ( when updating anything in the DSL ) - query/API action update - JS action update Fixes #37055 ## Tests on DP Deploy-Preview-URL: https://ce-37127.dp.appsmith.com/ - [x] Multiple widgets with the same bindings impacting the sequence of onPageLoadActions - onPageLoadActions update as expected when - [x] DSL is updated - [x] Query is updated - [x] JS Object is updated EE PR - https://github.com/appsmithorg/appsmith-ee/pull/5642 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12082854290> > Commit: 07b68d4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12082854290&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 29 Nov 2024 11:44:31 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced retrieval of possible entity references and their relationships with a new method. - Added new test cases to validate action execution on page load and dynamic binding handling. - **Bug Fixes** - Improved error handling and validation for executable references. - Enhanced assertions to ensure correct execution of layout actions. - **Tests** - Added a test to validate layout actions with multiple widgets referencing the same action. - Refactored existing tests for better readability and maintainability. - Expanded test coverage for layout updates and dynamic binding scenarios.  --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>

The chain+link framework is now used for all the steps in the backup command. ## Automation /test sanity ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12080116829> > Commit: fcc016f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12080116829&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 29 Nov 2024 07:12:22 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced new classes for managing backup processes, including `BackupFolderLink`, `DiskSpaceLink`, `EnvFileLink`, `GitStorageLink`, `MongoDumpLink`, and `ManifestLink`. - Added functionality for checking available disk space and managing temporary backup folders. - Enhanced encryption handling with a new password prompt mechanism. - **Bug Fixes** - Streamlined backup process by removing redundant functions and ensuring proper error handling. - **Documentation** - Updated comments and documentation for new classes and methods to improve clarity. - **Refactor** - Restructured backup functionality for improved modularity and maintainability.

coderabbitai · 2024-12-02T06:19:05Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sondermanish and others added 9 commits November 29, 2024 13:41

chore: Always get version from $backend (#37857)

d9b1a32

chore: Find version after backend is ready (#37861)

362b726

btsgh requested a review from shadabbuchh December 2, 2024 06:18

btsgh requested review from a team, nidhi-nair, sharat87 and sondermanish as code owners December 2, 2024 06:18

btsgh requested review from AnaghHegde and removed request for a team December 2, 2024 06:18

shadabbuchh approved these changes Dec 2, 2024

View reviewed changes

btsgh merged commit 5ef0e94 into master Dec 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

02/12 Daily Promotion#37866

02/12 Daily Promotion#37866
btsgh merged 9 commits intomasterfrom
release

btsgh commented Dec 2, 2024

Uh oh!

coderabbitai bot commented Dec 2, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

btsgh commented Dec 2, 2024

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Dec 2, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants