Skip to content

chore: Always get version from $backend #37857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharat87 merged 2 commits into from
Nov 29, 2024
Merged

chore: Always get version from $backend #37857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38f9a09
chore: Always get version from $backend
sharat87 Nov 29, 2024
0ce2dfa
fix localhost alis
sharat87 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions app/client/start-https.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,11 @@ if [[ ${backend-} == release ]]; then
backend=https://release.app.appsmith.com
fi

if [[ ${backend-} == *.appsmith.com ]]; then
# If running client against release, we get the release's version and set it up, so we don't see version mismatches.
APPSMITH_VERSION_ID="$(
curl -sS "$backend/info" | grep -Eo '"version": ".+?"' | cut -d\" -f4
)"
export APPSMITH_VERSION_ID
fi
# Try to get a version from the "backend". If it's a full container, not just backend, then it'll give us a version.
APPSMITH_VERSION_ID="$(
curl -sS "${backend/host.docker.internal/localhost}/info" | grep -Eo '"version": ".+?"' | cut -d\" -f4
)"
export APPSMITH_VERSION_ID

if [[ -z ${run_as-} ]]; then
if type nginx; then
Expand Down