chore: added SLA buckets for histogram metrics#37778
chore: added SLA buckets for histogram metrics#37778ApekshaBhosale wants to merge 1 commit intoreleasefrom
Conversation
WalkthroughThe pull request introduces a new configuration property in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/server/appsmith-server/src/main/resources/application.properties (1)
102-102: Consider optimizing SLA bucket distributionWhile the implementation is correct, consider the following suggestions:
- The 1000000ms (1000s) bucket seems excessive for HTTP requests
- Consider adding intermediate buckets between 5s and 10s
- Document the reasoning behind these specific bucket choices
Consider adjusting the buckets to better reflect typical web request patterns:
-management.metrics.distribution.sla.http.server.requests=100ms,300ms,500ms,1000ms,3000ms,5000ms,10000ms,1000000ms +management.metrics.distribution.sla.http.server.requests=100ms,300ms,500ms,1000ms,3000ms,5000ms,7500ms,10000ms,30000ms
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
app/server/appsmith-server/src/main/resources/application.properties(1 hunks)
🔇 Additional comments (1)
app/server/appsmith-server/src/main/resources/application.properties (1)
102-102: Verify metrics configuration integration
The SLA configuration requires proper integration with Spring Boot Actuator metrics. Let's verify the setup:
✅ Verification successful
Metrics configuration is properly integrated
The configuration is correctly set up with:
- Prometheus and metrics endpoints exposed
- Prometheus metric descriptions enabled
- HTTP server request histogram percentiles enabled
- No conflicting SLA configurations found
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify metrics configuration
# Check for required metric configurations and potential conflicts
# Look for metric-related configurations
echo "Checking metric configurations..."
rg -i "management\.(metrics|endpoints|prometheus)"
# Look for any potential duplicate SLA configurations
echo "Checking for duplicate SLA configurations..."
rg "management\.metrics\.distribution\.sla"
Length of output: 1043
|
/build-deploy-preview skip-test=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12048987325. |
Failed server tests
|
|
Deploy-Preview-URL: https://ce-37778.dp.appsmith.com |
ApekshaBhosale
changed the title
github-actions
bot
added
the
skip-changelog
2 participants
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit