Skip to content

CI : fix build cache #37712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yatinappsmith merged 2 commits into from
Nov 26, 2024
Merged

CI : fix build cache #37712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3980118
added git lfs migrate to server
yatinappsmith Nov 26, 2024
e721174
added git lfs migrate to clientbuild
yatinappsmith Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/client-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ jobs:
git config --global user.name "$gituser"
git clone https://$cachetoken@github.com/appsmithorg/cibuildcache.git
git lfs install
git lfs migrate import --everything
if [ "$reponame" = "appsmith" ]; then export repodir="CE"; fi
if [ "$reponame" = "appsmith-ee" ]; then export repodir="EE"; fi
cd cibuildcache/$repodir/release/client
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/server-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ jobs:
git config --global user.name "$gituser"
git clone https://$cachetoken@github.com/appsmithorg/cibuildcache.git
git lfs install
git lfs migrate import --everything
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Git LFS setup is missing but required for large files

The repository contains multiple large files (>1MB), particularly video files up to 45MB, but Git LFS is not configured (.gitattributes missing). This will cause the git lfs migrate import command to fail.

  • Add .gitattributes file with appropriate patterns: 
    *.y4m filter=lfs diff=lfs merge=lfs -text
*.mov filter=lfs diff=lfs merge=lfs -text
*.gif filter=lfs diff=lfs merge=lfs -text
  • Install Git LFS before running the migration command
🔗 Analysis chain

Verify Git LFS migration impact

The git lfs migrate import --everything command might cause issues if not all files are properly tracked in Git LFS. Consider using selective migration or verifying the tracked patterns first.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check Git LFS tracked patterns
git lfs track

# Verify size of files that would be migrated
git lfs migrate info --everything

Length of output: 221

Script:

#!/bin/bash
# Check if .gitattributes exists and contains LFS configurations
if [ -f ".gitattributes" ]; then
    echo "Content of .gitattributes:"
    cat .gitattributes
else
    echo ".gitattributes not found"
fi

# Search for large files in the repository
echo -e "\nLarge files (>1MB) in the repository:"
find . -type f -size +1M -not -path "*/\.*" -exec ls -lh {} \;

# Check if there are any existing LFS references
echo -e "\nSearching for LFS pointers:"
find . -type f -not -path "*/\.*" -exec grep -l "version https://git-lfs.github.com/spec/" {} \;

Length of output: 4157

if [ "$reponame" = "appsmith" ]; then export repodir="CE"; fi
if [ "$reponame" = "appsmith-ee" ]; then export repodir="EE"; fi
cd cibuildcache/$repodir/release/server
Expand Down