chore: Error Tab changes for Debugger

app/client/packages/design-system/ads/src/Icon/Icon.provider.tsx

@@ -1072,6 +1072,10 @@ const InputCursorMoveIcon = importSvg(
   async () => import("../__assets__/icons/ads/input-cursor-move.svg"),
 );
 
+const DebugIcon = importSvg(
+  async () => import("../__assets__/icons/ads/debug.svg"),
+);
+
 import PlayIconPNG from "../__assets__/icons/control/play-icon.png";
 
 function PlayIconPNGWrapper() {
@@ -1113,6 +1117,7 @@ const ICON_LOOKUP = {
   "show-column": EyeIcon,
   "hide-column": EyeOffIcon,
   "delete-column": DeleteColumnIcon,
+  debug: DebugIcon,
   "bold-font": BoldFontIcon,
   underline: UnderlineIcon,
   "italics-font": ItalicsFontIcon,

app/client/src/ce/constants/messages.ts

@@ -556,7 +556,7 @@ export const LOGS_FILTER_OPTION_CONSOLE = () => "Console logs";
 export const LOGS_FILTER_OPTION_SYSTEM = () => "System logs";
 export const NO_LOGS = () => "No logs to show";
 export const NO_ERRORS = () => "No signs of trouble here!";
-export const DEBUGGER_ERRORS = () => "Errors";
+export const DEBUGGER_ERRORS = () => "Linter";
 export const DEBUGGER_RESPONSE = () => "Response";
 export const DEBUGGER_HEADERS = () => "Headers";
 export const DEBUGGER_LOGS = () => "Logs";

app/client/src/components/editorComponents/Debugger/DebuggerTabs.tsx

@@ -13,12 +13,10 @@ import {
 } from "selectors/debuggerSelectors";
 import AnalyticsUtil from "ee/utils/AnalyticsUtil";
 import Errors from "./Errors";
-import EntityDeps from "./EntityDependecies";
 import {
   createMessage,
   DEBUGGER_ERRORS,
   DEBUGGER_LOGS,
-  INSPECT_ENTITY,
 } from "ee/constants/messages";
 import { DEBUGGER_TAB_KEYS } from "./constants";
 import EntityBottomTabs from "../EntityBottomTabs";
@@ -59,11 +57,6 @@ function DebuggerTabs() {
       title: createMessage(DEBUGGER_LOGS),
       panelComponent: <DebuggerLogs hasShortCut />,
     },
-    {
-      key: DEBUGGER_TAB_KEYS.INSPECT_TAB,
-      title: createMessage(INSPECT_ENTITY),
-      panelComponent: <EntityDeps />,
-    },
   ];
 
   // Do not render if response, header or schema tab is selected in the bottom bar.

app/client/src/components/editorComponents/Debugger/index.tsx

@@ -3,9 +3,8 @@ import { useDispatch, useSelector } from "react-redux";
 import DebuggerTabs from "./DebuggerTabs";
 import { setErrorCount } from "actions/debuggerActions";
 import { getMessageCount, showDebuggerFlag } from "selectors/debuggerSelectors";
-import { Tooltip } from "@appsmith/ads";
+import { Tooltip, Button } from "@appsmith/ads";
 import useDebuggerTriggerClick from "./hooks/useDebuggerTriggerClick";
-import * as Styled from "./styles";
 
 function Debugger() {
   // Debugger render flag
@@ -32,19 +31,24 @@ export function DebuggerTrigger() {
         }`
       : `No errors`;
 
+  const countContent =
+    messageCounters.errors !== 0
+      ? messageCounters.errors > 99
+        ? "(99+)"
+        : `(${messageCounters.errors})`
+      : "";
+
   return (
     <Tooltip content={tooltipContent}>
-      <Styled.DebuggerTriggerButton
+      <Button
         className="t--debugger-count"
         kind={messageCounters.errors > 0 ? "error" : "tertiary"}
         onClick={onClick}
         size="md"
-        startIcon={
-          messageCounters.errors ? "close-circle" : "close-circle-line"
-        }
+        startIcon="debug"
       >
-        {messageCounters.errors > 99 ? "99+" : messageCounters.errors}
-      </Styled.DebuggerTriggerButton>
+        Debug {countContent}
+      </Button>
     </Tooltip>
   );
 }

app/client/src/pages/Editor/DataSourceEditor/Debugger.tsx

@@ -5,7 +5,6 @@ import {
   createMessage,
   DEBUGGER_ERRORS,
   DEBUGGER_LOGS,
-  INSPECT_ENTITY,
 } from "ee/constants/messages";
 import {
   setDebuggerSelectedTab,
@@ -16,7 +15,6 @@ import EntityBottomTabs from "components/editorComponents/EntityBottomTabs";
 import { DEBUGGER_TAB_KEYS } from "components/editorComponents/Debugger/constants";
 import Errors from "components/editorComponents/Debugger/Errors";
 import DebuggerLogs from "components/editorComponents/Debugger/DebuggerLogs";
-import EntityDeps from "components/editorComponents/Debugger/EntityDependecies";
 import {
   getDebuggerSelectedTab,
   getErrorCount,
@@ -100,11 +98,6 @@ export default function Debugger() {
       title: createMessage(DEBUGGER_LOGS),
       panelComponent: <DebuggerLogs hasShortCut />,
     },
-    {
-      key: DEBUGGER_TAB_KEYS.INSPECT_TAB,
-      title: createMessage(INSPECT_ENTITY),
-      panelComponent: <EntityDeps />,
-    },
   ];
 
   // set the height of the response pane in the store

app/client/src/sagas/ActionExecution/PluginActionSaga.ts

@@ -59,12 +59,11 @@ import {
   isArrayBuffer,
   isEmpty,
   isNil,
-  isString,
   set,
   unset,
 } from "lodash";
 import AppsmithConsole from "utils/AppsmithConsole";
-import { ENTITY_TYPE, PLATFORM_ERROR } from "ee/entities/AppsmithConsole/utils";
+import { ENTITY_TYPE } from "ee/entities/AppsmithConsole/utils";
 import {
   extractClientDefinedErrorMetadata,
   validateResponse,
@@ -576,10 +575,6 @@ export default function* executePluginActionTriggerSaga(
   const plugin: Plugin = yield select(getPlugin, action?.pluginId);
   const currentApp: ApplicationPayload = yield select(getCurrentApplication);
 
-  const currentEnvDetails: { id: string; name: string } = yield select(
-    getCurrentEnvironmentDetails,
-  );
-
   const pluginActionNameToDisplay = getPluginActionNameToDisplay(action);
 
   const actionExecutionAnalytics = getActionExecutionAnalytics(
@@ -618,40 +613,6 @@ export default function* executePluginActionTriggerSaga(
   const { isError, payload } = executePluginActionResponse;
 
   if (isError) {
-    AppsmithConsole.addErrors([
-      {
-        payload: {
-          id: actionId,
-          iconId: action.pluginId,
-          logType: LOG_TYPE.ACTION_EXECUTION_ERROR,
-          text: `Execution failed with status ${payload.statusCode}`,
-          environmentName: currentEnvDetails.name,
-          source: {
-            type: ENTITY_TYPE.ACTION,
-            name: pluginActionNameToDisplay,
-            id: actionId,
-            httpMethod: action?.actionConfiguration?.httpMethod,
-            pluginType: action.pluginType,
-          },
-          state: payload.request,
-          messages: [
-            {
-              // Need to stringify cause this gets rendered directly
-              // and rendering objects can crash the app
-              message: {
-                name: "PluginExecutionError",
-                message: !isString(payload.body)
-                  ? JSON.stringify(payload.body)
-                  : payload.body,
-              },
-              type: PLATFORM_ERROR.PLUGIN_EXECUTION,
-              subType: payload.errorType,
-            },
-          ],
-          pluginErrorDetails: payload.pluginErrorDetails,
-        },
-      },
-    ]);
     AnalyticsUtil.logEvent("EXECUTE_ACTION_FAILURE", {
       ...actionExecutionAnalytics,
       ...payload.pluginErrorDetails,
@@ -926,54 +887,10 @@ export function* runActionSaga(
     error =
       readableError || payloadBodyError || clientDefinedError || defaultError;
 
-    // In case of debugger, both the current error message
-    // and the readableError needs to be present,
-    // since the readableError may be malformed for certain errors.
-
-    const appsmithConsoleErrorMessageList = [
-      {
-        message: error,
-        type: PLATFORM_ERROR.PLUGIN_EXECUTION,
-        subType: payload.errorType,
-      },
-    ];
-
-    if (error === readableError && !!payloadBodyError) {
-      appsmithConsoleErrorMessageList.push({
-        message: payloadBodyError,
-        type: PLATFORM_ERROR.PLUGIN_EXECUTION,
-        subType: payload.errorType,
-      });
-    }
-
-    AppsmithConsole.addErrors([
-      {
-        payload: {
-          id: actionId,
-          iconId: actionObject.pluginId,
-          logType: LOG_TYPE.ACTION_EXECUTION_ERROR,
-          environmentName: currentEnvDetails.name,
-          text: `Execution failed${
-            payload.statusCode ? ` with status ${payload.statusCode}` : ""
-          }`,
-          source: {
-            type: ENTITY_TYPE.ACTION,
-            name: pluginActionNameToDisplay,
-            id: actionId,
-            httpMethod: actionObject?.actionConfiguration?.httpMethod,
-            pluginType: actionObject.pluginType,
-          },
-          messages: appsmithConsoleErrorMessageList,
-          state: payload?.request,
-          pluginErrorDetails: payload?.pluginErrorDetails,
-        },
-      },
-    ]);
-
     yield put({
       type: ReduxActionErrorTypes.RUN_ACTION_ERROR,
       payload: {
-        error: appsmithConsoleErrorMessageList[0].message,
+        error,
         id: reduxAction.payload.id,
         show: false,
       },
@@ -1215,34 +1132,6 @@ function* executePageLoadAction(
       );
 
     if (isError) {
-      AppsmithConsole.addErrors([
-        {
-          payload: {
-            id: pageAction.id,
-            iconId: action.pluginId,
-            logType: LOG_TYPE.ACTION_EXECUTION_ERROR,
-            environmentName: currentEnvDetails.name,
-            text: `Execution failed with status ${payload.statusCode}`,
-            source: {
-              type: ENTITY_TYPE.ACTION,
-              name: actionName,
-              id: pageAction.id,
-              httpMethod: action?.actionConfiguration?.httpMethod,
-              pluginType: action.pluginType,
-            },
-            state: payload.request,
-            messages: [
-              {
-                message: error,
-                type: PLATFORM_ERROR.PLUGIN_EXECUTION,
-                subType: payload.errorType,
-              },
-            ],
-            pluginErrorDetails: payload.pluginErrorDetails,
-          },
-        },
-      ]);
-
       yield put(
         executePluginActionError({
           actionId: pageAction.id,

app/client/src/sagas/JSPaneSagas.ts

@@ -67,14 +67,12 @@ import {
   createMessage,
   ERROR_JS_COLLECTION_RENAME_FAIL,
   JS_EXECUTION_SUCCESS,
-  JS_EXECUTION_FAILURE,
   JS_FUNCTION_CREATE_SUCCESS,
   JS_FUNCTION_DELETE_SUCCESS,
 } from "ee/constants/messages";
 import { validateResponse } from "./ErrorSagas";
 import AppsmithConsole from "utils/AppsmithConsole";
-import { ENTITY_TYPE, PLATFORM_ERROR } from "ee/entities/AppsmithConsole/utils";
-import LOG_TYPE from "entities/AppsmithConsole/logtype";
+import { ENTITY_TYPE } from "ee/entities/AppsmithConsole/utils";
 import { updateCanvasWithDSL } from "ee/sagas/PageSagas";
 import { set } from "lodash";
 import { updateReplayEntity } from "actions/pageActions";
@@ -539,32 +537,9 @@ export function* handleExecuteJSFunctionSaga(data: {
       );
     }
 
-    if (!!collection.isMainJSCollection)
+    if (!!collection.isMainJSCollection) {
       logMainJsActionExecution(actionId, false, collectionId, false);
-
-    AppsmithConsole.addErrors([
-      {
-        payload: {
-          id: actionId,
-          logType: LOG_TYPE.ACTION_EXECUTION_ERROR,
-          text: createMessage(JS_EXECUTION_FAILURE),
-          source: {
-            type: ENTITY_TYPE.JSACTION,
-            name: jsActionPathNameToDisplay,
-            id: collectionId,
-          },
-          messages: [
-            {
-              message: {
-                name: (error as Error).name,
-                message: (error as Error).message,
-              },
-              type: PLATFORM_ERROR.PLUGIN_EXECUTION,
-            },
-          ],
-        },
-      },
-    ]);
+    }
   }
 }