Skip to content

chore: Remove unused netcat and openssh-client #37662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharat87 merged 2 commits into from
Nov 23, 2024
Merged

chore: Remove unused netcat and openssh-client #37662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34dce2d
chore: Remove unused `netcat` and `openssh-client`
sharat87 Nov 23, 2024
5f83399
Rabbit!
sharat87 Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions deploy/docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,7 @@ This will need a restart of the Appsmith server, which can be done using the fol
```sh
docker-compose exec appsmith-ce supervisorctl restart backend
```
### Migrate To New Server
To migrate a running container to a new server or other machine, you can use the following `migrate` command and replace the `<user>` and `<new-server-ip-address>` by the user and IP address of the destination server or machine.
```
docker exec appsmith-ce appsmithctl migrate <user>@<new-server-ip-address>
```
This command will migrate all data and configuration of running container on source machine to destination machine and start a new container on destination machine.

## Supervisor

The container runs multiple processes, including the Appsmith server, Nginx, MongoDB etc., inside a single Docker container. These processes are started and managed by [supervisord](http://supervisord.org/).
Expand Down
2 changes: 1 addition & 1 deletion deploy/docker/base.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ RUN set -o xtrace \
&& apt-get update \
&& apt-get upgrade --yes \
&& DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends --yes \
supervisor curl nfs-common gnupg wget netcat openssh-client \
supervisor curl nfs-common gnupg wget \
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Documentation needs to be updated to remove deprecated migrate command reference

The packages can be safely removed, but the README.md still contains a reference to the deprecated appsmithctl migrate command in the "Migrate To New Server" section.

  • deploy/docker/README.md: Remove or update the "Migrate To New Server" section as the command is no longer supported
🔗 Analysis chain

Verify removal of netcat and openssh-client dependencies

The removal of these packages aligns with the deprecation of the appsmithctl migrate command.

Let's verify there are no remaining references to these packages or the migrate command:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to netcat, openssh-client, or migrate command
rg -i "netcat|openssh-client|appsmithctl migrate"

Length of output: 150

Script:

#!/bin/bash
# Check the README.md content for context around the migrate command
cat deploy/docker/README.md

Length of output: 9529

Copy link
Member Author

@sharat87 sharat87 Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@coderabbitai coderabbitai bot Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharat87, thank you for updating the documentation!

If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!

gettext \
ca-certificates \
# Install MongoDB v5, Redis, PostgreSQL v13
Expand Down