Skip to content

chore: Refactor observability setup. Migrate monitoring configuration…#37577

Merged
subhrashisdas merged 1 commit intoreleasefrom
feature/cleanup-observability
Nov 20, 2024
Merged

chore: Refactor observability setup. Migrate monitoring configuration…#37577
subhrashisdas merged 1 commit intoreleasefrom
feature/cleanup-observability

Conversation

@subhrashisdas
Copy link
Member

@subhrashisdas subhrashisdas commented Nov 20, 2024

Description

Cleanup of Monitoring will be done in multiple phases to avoid any disruptions. The first PR is to remove the default monitoring Compose files.

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11929368913
Commit: af90c5f
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Wed, 20 Nov 2024 08:55:56 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Removed several configuration files related to observability tools, including Docker Compose, Grafana dashboards, data sources, and Prometheus settings.
    • These changes streamline the observability setup by eliminating outdated or unused configurations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2024

Walkthrough

The changes involve the deletion of several configuration files related to observability tools in a Docker setup. The removed files include configurations for Docker Compose, Grafana dashboards, data sources, and Prometheus settings, as well as a local Tempo configuration. These deletions indicate a significant alteration in the observability setup, potentially simplifying or changing the approach to monitoring and logging within the application.

Changes

File Path Change Summary
utils/observability/docker-compose.yml Deleted configuration for Docker Compose, including services for Tempo, Prometheus, and Grafana.
utils/observability/docker/grafana/provisioning/dashboards/dashboard.yml Deleted Grafana dashboard provisioning configuration.
utils/observability/docker/grafana/provisioning/dashboards/logs_traces_metrics.json Deleted Grafana dashboard for visualizing logs, traces, and metrics.
utils/observability/docker/grafana/provisioning/dashboards/redis_dashboard.json Deleted Grafana dashboard specifically for monitoring Redis operations.
utils/observability/docker/grafana/provisioning/datasources/datasource.yml Deleted configuration for data sources (Prometheus, Tempo, Loki) in Grafana.
utils/observability/docker/prometheus/prometheus.yml Deleted configuration settings for Prometheus monitoring.
utils/observability/docker/tempo/tempo-local.yaml Deleted configuration for local Tempo instance setup.

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

  • sharat87
  • ApekshaBhosale
  • rajatagrawal
  • nidhi-nair

🌟 In the land of code where changes flow,
Configs were deleted, and off they go!
With observability tools now out of sight,
A simpler path may soon feel just right.
Farewell to the dashboards and YAMLs galore,
New adventures await, let’s code even more! 🚀


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7e13fcb and af90c5f.

📒 Files selected for processing (7)
  • utils/observability/docker-compose.yml (0 hunks)
  • utils/observability/docker/grafana/provisioning/dashboards/dashboard.yml (0 hunks)
  • utils/observability/docker/grafana/provisioning/dashboards/logs_traces_metrics.json (0 hunks)
  • utils/observability/docker/grafana/provisioning/dashboards/redis_dashboard.json (0 hunks)
  • utils/observability/docker/grafana/provisioning/datasources/datasource.yml (0 hunks)
  • utils/observability/docker/prometheus/prometheus.yml (0 hunks)
  • utils/observability/docker/tempo/tempo-local.yaml (0 hunks)
💤 Files with no reviewable changes (7)
  • utils/observability/docker-compose.yml
  • utils/observability/docker/grafana/provisioning/dashboards/dashboard.yml
  • utils/observability/docker/grafana/provisioning/dashboards/logs_traces_metrics.json
  • utils/observability/docker/grafana/provisioning/dashboards/redis_dashboard.json
  • utils/observability/docker/grafana/provisioning/datasources/datasource.yml
  • utils/observability/docker/prometheus/prometheus.yml
  • utils/observability/docker/tempo/tempo-local.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Nov 20, 2024
@subhrashisdas subhrashisdas added the ok-to-test Required label for CI label Nov 20, 2024
@subhrashisdas subhrashisdas enabled auto-merge (squash) November 20, 2024 06:44
@subhrashisdas subhrashisdas added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Nov 20, 2024
@subhrashisdas subhrashisdas merged commit 7b81c3e into release Nov 20, 2024
@subhrashisdas subhrashisdas deleted the feature/cleanup-observability branch November 20, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants