Skip to content

chore: Rename app-viewers to widgets-blocks #37553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharat87 merged 1 commit into from
Nov 20, 2024
Merged

chore: Rename app-viewers to widgets-blocks #37553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ app/client/src/widgets/wds/* @appsmithorg/wds-team @appsmithorg/anvil-team
app/client/src/layoutSystems/anvil/* @appsmithorg/anvil-team

# App viewers pod
app/client/src/widgets/* @appsmithorg/app-viewers
app/client/src/components/propertyControls/* @appsmithorg/app-viewers
app/client/src/sagas/OneClickBindingSaga.ts @appsmithorg/app-viewers
app/client/src/WidgetQueryGenerators/* @appsmithorg/app-viewers
app/client/src/components/editorComponents/WidgetQueryGeneratorForm/* @appsmithorg/app-viewers
app/client/src/pages/AppViewer/* @appsmithorg/app-viewers
app/client/src/widgets/* @appsmithorg/widgets-blocks
app/client/src/components/propertyControls/* @appsmithorg/widgets-blocks
app/client/src/sagas/OneClickBindingSaga.ts @appsmithorg/widgets-blocks
app/client/src/WidgetQueryGenerators/* @appsmithorg/widgets-blocks
app/client/src/components/editorComponents/WidgetQueryGeneratorForm/* @appsmithorg/widgets-blocks
app/client/src/pages/AppViewer/* @appsmithorg/widgets-blocks
Comment on lines +30 to +35
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Ownership conflicts detected in CODEOWNERS file

There are overlapping ownership assignments that need to be resolved:

  • app/client/src/widgets/* has conflicting ownership:

    • Line 30: @appsmithorg/widgets-blocks
    • Lines 87-92: @appsmithorg/anvil-team (specific files)
    • Line 24: @appsmithorg/wds-team & @appsmithorg/anvil-team (wds subdirectory)

  • app/client/src/components/propertyControls/* has conflicting ownership:

    • Line 31: @appsmithorg/widgets-blocks
    • Line 59: @appsmithorg/anvil-team

Please clarify the ownership hierarchy and resolve these conflicts to prevent confusion in code review assignments.

🔗 Analysis chain

LGTM! Ownership reassignment is consistent with PR objectives.

The ownership transfer from @appsmithorg/app-viewers to @appsmithorg/widgets-blocks is properly implemented for all widget-related paths.

Let's verify there are no ownership conflicts with other teams:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for paths that might have multiple owners

# Test: Look for duplicate path definitions
rg -n "^app/client/src/widgets/\*" CODEOWNERS
rg -n "^app/client/src/components/propertyControls/\*" CODEOWNERS
rg -n "^app/client/src/pages/AppViewer/\*" CODEOWNERS

Length of output: 4973

Script:

#!/bin/bash
# Let's try a different approach to check for ownership conflicts
# 1. Get all lines containing the paths we're interested in
grep -n "app/client/src/widgets\|app/client/src/components/propertyControls\|app/client/src/pages/AppViewer" CODEOWNERS

# 2. Also check for any other team assignments in these directories
grep -n "widgets-blocks\|app-viewers" CODEOWNERS

Length of output: 1358


# New Developers Pod
app/server/appsmith-server/src/main/java/com/appsmith/server/featureflags/* @nilanshbansal
Expand Down