chore: Abstraction of Bottom View in Cypress #37410
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,21 @@ | ||||||||||
| class Response { | ||||||||||
| private ResponseTab = "//button[@data-testid='t--tab-RESPONSE_TAB']"; | ||||||||||
|
Comment on lines
+1
to
+2
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Replace XPath selector with data- attribute selector* The XPath selector usage violates our coding guidelines. Use data-* attributes for more maintainable selectors. class Response {
- private ResponseTab = "//button[@data-testid='t--tab-RESPONSE_TAB']";
+ private ResponseTab = "[data-testid='t--tab-RESPONSE_TAB']";📝 Committable suggestion
Suggested change
|
||||||||||
|
|
||||||||||
| public switchToResponseTab(): void { | ||||||||||
| cy.xpath(this.ResponseTab).click({ force: true }); | ||||||||||
| } | ||||||||||
|
Comment on lines
+4
to
+6
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Avoid force clicks and XPath in Cypress commands Force clicks can make tests brittle and mask underlying issues. Consider adding proper wait conditions or element visibility checks. public switchToResponseTab(): void {
- cy.xpath(this.ResponseTab).click({ force: true });
+ cy.get(this.ResponseTab)
+ .should('be.visible')
+ .click();
}
|
||||||||||
|
|
||||||||||
| public getResponseTypeSelector(type: string): string { | ||||||||||
| return `//div[@data-testid='t--response-tab-segmented-control']//span[text()='${type}']`; | ||||||||||
| } | ||||||||||
|
Comment on lines
+8
to
+10
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Use data attributes for response type selection String interpolation in selectors is fragile. Consider using data attributes with specific values for each type. public getResponseTypeSelector(type: string): string {
- return `//div[@data-testid='t--response-tab-segmented-control']//span[text()='${type}']`;
+ return `[data-testid='t--response-type-${type.toLowerCase()}']`;
}
|
||||||||||
|
|
||||||||||
| public switchResponseType(type: string): void { | ||||||||||
| this.switchToResponseTab(); | ||||||||||
| cy.xpath(this.getResponseTypeSelector(type)).click({ force: true }); | ||||||||||
| } | ||||||||||
|
Comment on lines
+12
to
+15
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Improve response type switching reliability Similar to the tab switching, avoid force clicks and use proper wait conditions. public switchResponseType(type: string): void {
this.switchToResponseTab();
- cy.xpath(this.getResponseTypeSelector(type)).click({ force: true });
+ cy.get(this.getResponseTypeSelector(type))
+ .should('be.visible')
+ .click();
}
|
||||||||||
|
|
||||||||||
| // TODO: Implement this method when response UI is ready | ||||||||||
| public validateRecordCount(count: number): void {} | ||||||||||
| } | ||||||||||
|
|
||||||||||
| export { Response }; | ||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { Response } from "./Response"; | ||
|
|
||
| class BottomPane { | ||
| public readonly response: Response; | ||
|
|
||
| constructor() { | ||
| this.response = new Response(); | ||
| } | ||
| } | ||
|
|
||
| export default new BottomPane(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
agHelper.Sleep(1000)Replace the sleep with proper Cypress wait commands or assertions to ensure the page has loaded.
Apply this change: