TESTING EXTERNAL SCRIPT: external merge request from Contributor

[sneha122]

Description

• Shadow PR for fix: SMTP datasource should work without username and password #37319

Fixes #

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11836982900
Commit: 51eb3bb
Cypress dashboard.
Tags: @tag.All
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

---

Thu, 14 Nov 2024 12:21:29 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Enhanced SMTP plugin flexibility by allowing connections without authentication if credentials are not provided.
  • Simplified datasource validation to focus solely on valid host addresses.

• Bug Fixes

  • Improved error handling in the datasource testing process, enhancing robustness.

• Tests

  • Added new test capabilities for SMTP connections without authentication.
  • Updated existing tests to reflect changes in authentication handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on the SmtpPlugin.java and SmtpPluginTest.java files. Key modifications include enhancements to the datasourceCreate and validateDatasource methods to improve authentication handling and validation logic for the SMTP plugin. The test suite has also been updated to support scenarios without authentication, including the introduction of a new test container and adjustments to test method names and logic.

Changes

File	Change Summary
app/server/appsmith-plugins/smtpPlugin/src/main/java/com/external/plugins/SmtpPlugin.java	Updated datasourceCreate to handle authentication conditionally; simplified validateDatasource by removing auth checks; improved exception handling in testDatasource.
app/server/appsmith-plugins/smtpPlugin/src/test/java/com/external/plugins/SmtpPluginTest.java	Added smtpWithoutAuth container for testing without authentication; renamed testNullAuthentication to testConnectionWithoutAuth; reorganized imports and updated setup method.

Suggested labels

Bug, Task, Datasources, Integrations Pod General

Suggested reviewers

• ankitakinger

In the land of code where plugins reside,
SMTP's journey takes a new stride.
With checks for auth now flexible and bright,
Testing connections, both day and night.
A container for ease, a method refined,
In the world of Java, progress we find! 🌟

Warning

Rate limit exceeded

@sneha122 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 17537e7 and 51eb3bb.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sneha122]

Closing this as TEST

[github-actions]

Failed server tests

• com.appsmith.server.configurations.CommonConfigTest#objectMapper_BeanCreated_WithPublicJsonViewAsDefault