Skip to content

chore: Updating the function icon on JS editor #37340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitakinger merged 3 commits into from
Nov 13, 2024
Merged

chore: Updating the function icon on JS editor #37340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec2833e
updating the js function icon
ankitakinger Nov 12, 2024
c857505
addressing coderabbit comments
ankitakinger Nov 12, 2024
1e8555b
addressing review comment
ankitakinger Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/client/packages/design-system/ads/src/Icon/Icon.provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,6 +963,9 @@ const JSFile = importSvg(
const JSFunction = importSvg(
async () => import("../__assets__/icons/menu/js-function.svg"),
);
const JSFunctionV2 = importSvg(
async () => import("../__assets__/icons/menu/js-function-v2.svg"),
);
const QueryMain = importSvg(
async () => import("../__assets__/icons/menu/query-main.svg"),
);
Expand Down Expand Up @@ -1285,6 +1288,7 @@ const ICON_LOOKUP = {
"js-icon-v2": JSIconV2,
"js-file": JSFile,
"js-function": JSFunction,
"js-function-v2": JSFunctionV2,
"datasources-2": Datasources2,
"arrow-left-line": ArrowLeftLineIcon,
"arrow-right-line": ArrowRightLineIcon,
Expand Down
5 changes: 5 additions & 0 deletions app/client/packages/design-system/ads/src/__assets__/icons/menu/js-function-v2.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions app/client/src/components/editorComponents/ActionCreator/helpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ export function getJSOptions(
id: js.id,
value: jsAction.config.name + "." + js.name,
type: jsOption.value,
icon: <Icon name="js-function" size="md" />,
icon: <Icon name="js-function-v2" size="md" />,
args: argValue,
};

Expand Down Expand Up @@ -658,7 +658,7 @@ export function getJSOptions(
id: js.id,
value: jsModuleInstance.name + "." + js.name,
type: jsOption.value,
icon: <Icon name="js-function" size="md" />,
icon: <Icon name="js-function-v2" size="md" />,
args: argValue,
};

Expand Down
2 changes: 1 addition & 1 deletion app/client/src/pages/Editor/JSEditor/JSEditorToolbar/components/JSFunctionRun.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const JSFunctionRun = (props: Props) => {
isDisabled={props.disabled}
kind="tertiary"
size="sm"
startIcon="js-function"
startIcon="js-function-v2"
Comment thread
ankitakinger marked this conversation as resolved.
Outdated
>
{props.selected.label}
</Button>
Expand Down