chore: use spybean for SessionUserService and remove unused method for populating the userId in the ActionExecuteDTO

[nsarupr]

Description

Fix test case for EE

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11717655239
Commit: 87131cb
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 07 Nov 2024 06:49:49 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

Summary by CodeRabbit

• Tests
  • Updated the sessionUserService field in the test class to utilize partial mocking, enhancing the verification of interactions during tests.
• Bug Fixes
  • Removed the method responsible for populating user IDs in action execution, streamlining user identification handling.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifying the sessionUserService field in the ActionExecutionSolutionCEImplTest class from a @MockBean to a @SpyBean. This adjustment allows for partial mocking of the sessionUserService, enabling the test to verify interactions while retaining the original functionality of the service. Additionally, the populateExecuteActionDTOWithUserId method has been removed from the ActionExecutionSolutionCEImpl class, indicating a change in user ID management during action execution.

Changes

File	Change Summary
app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImplTest.java	Changed sessionUserService from @MockBean to @SpyBean.
app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java	Removed populateExecuteActionDTOWithUserId method.

Possibly related PRs

• base changes to populate system info to executeActionDTO #37091: Modifications to the ActionExecutionSolutionCEImplTest class, adding a mock bean for ActionExecutionSolutionHelper, which relates to the changes made in the main PR.

Suggested labels

Bug, Task

Suggested reviewers

• nidhi-nair
• sondermanish
• abhvsn

🎉 In the land of code where tests do play,
A @SpyBean emerged to save the day!
With partial mocks and services true,
Our tests now shine with a clearer view.
So here's to the changes, both bold and bright,
In the realm of Java, everything feels right! 🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between db81565 and 87131cb.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java (0 hunks)

💤 Files with no reviewable changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.