chore: fixed type issue for moduleInstances

[vsvamsi1]

Description

Fixed type issue for moduleInstances in the dataTreeFactory.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11668431804
Commit: 1e988df
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Mon, 04 Nov 2024 17:20:56 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Enhanced type safety for the moduleInstanceEntities parameter in the DataTreeFactory class, improving clarity and maintainability.

• Bug Fixes

  • Removed the ESLint directive that suppressed warnings about the use of any, promoting stricter type enforcement.

[coderabbitai]

Walkthrough

The changes in this pull request involve updating the type of the moduleInstanceEntities parameter in the widgets method of the DataTreeFactory class from null to DataTreeSeed["moduleInstanceEntities"]. This adjustment enhances type safety within the codebase. Additionally, an ESLint directive suppressing warnings about the use of any has been removed, indicating a move towards stricter type enforcement. The overall structure and logic of the methods remain unchanged.

Changes

File Path	Change Summary
app/client/src/entities/DataTree/dataTreeFactory.ts	Updated moduleInstanceEntities parameter type in widgets method from null to DataTreeSeed["moduleInstanceEntities"]. Removed ESLint directive for any.

Possibly related PRs

• chore: Updating types for support on EE #37077: This PR updates types for props in components, enhancing type safety similar to the changes made in the main PR where the type of a parameter was updated to improve type safety.

Suggested labels

skip-changelog

Suggested reviewers

• ankitakinger
• sharat87

🎉 In the code where types do play,
A change was made, hooray, hooray!
From null to DataTreeSeed,
For clarity, this is the need!
With stricter types, we pave the way,
For cleaner code, come what may! 🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c42be90 and 1e988df.

📒 Files selected for processing (1)

• app/client/src/entities/DataTree/dataTreeFactory.ts (2 hunks)

🔇 Additional comments (2)

app/client/src/entities/DataTree/dataTreeFactory.ts (2)

27-27: LGTM! Clean type import addition.

The import is well-placed and follows the project's conventions.

---

60-60: Type improvement looks good, verify call sites.

The type change from null to DataTreeSeed["moduleInstanceEntities"] improves type safety.

Let's verify all call sites of this method to ensure compatibility:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

⚠️ Cyclic Dependency Check:

This PR has increased the number of cyclic dependencies by 1, when compared with the release branch.

Refer this document to identify the cyclic dependencies introduced by this PR.