Skip to content

feat: remove release_table_cell_label_value_enabled feature flag #37110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacquesikot merged 2 commits into from
Oct 28, 2024
Merged

feat: remove release_table_cell_label_value_enabled feature flag #37110

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0456914
feaet: remove feature flag
jacquesikot Oct 28, 2024
d225470
feat: remove feature flag from tests and FeatureFlag.ts
jacquesikot Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions app/client/src/widgets/TableWidgetV2/component/cellComponents/SelectCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { FEATURE_FLAG } from "ee/entities/FeatureFlag";
import React, { useCallback, useMemo } from "react";
import styled from "styled-components";
import { useFeatureFlag } from "utils/hooks/useFeatureFlag";
import SelectComponent from "widgets/SelectWidget/component";
import type { DropdownOption } from "widgets/SelectWidget/constants";
import type { EditableCellActions } from "widgets/TableWidgetV2/constants";
Expand Down Expand Up @@ -196,25 +194,17 @@ export const SelectCell = (props: SelectProps) => {
.map((d: DropdownOption) => d.value)
.indexOf(value);

const releaseTableSelectCellLabelValue = useFeatureFlag(
FEATURE_FLAG.release_table_cell_label_value_enabled,
);

const cellLabelValue = useMemo(() => {
if (releaseTableSelectCellLabelValue) {
if (!options.length) return value;
if (!options.length) return value;

const selectedOption = options.find(
(option) => option[TableSelectColumnOptionKeys.VALUE] === value,
);
const selectedOption = options.find(
(option) => option[TableSelectColumnOptionKeys.VALUE] === value,
);

return selectedOption
? selectedOption[TableSelectColumnOptionKeys.LABEL]
: "";
} else {
return value;
}
}, [releaseTableSelectCellLabelValue, value, options]);
return selectedOption
? selectedOption[TableSelectColumnOptionKeys.LABEL]
: "";
}, [value, options]);

if (isEditable && isCellEditable && isCellEditMode) {
return (
Expand Down