Skip to content

chore: Update dispatch option #37066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yatinappsmith merged 1 commit into from
Oct 25, 2024
Merged

chore: Update dispatch option #37066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/server-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,27 @@ on:
type: string
default: "false"

workflow_dispatch:
inputs:
pr:
description: "PR number for the workflow"
required: false
type: number
skip-tests:
description: "Skip tests flag"
required: false
type: string
default: "false"
branch:
description: "Branch for the build"
required: false
type: string
is-pg-build:
description: "Flag for PG build"
required: false
type: string
default: "false"
Comment on lines +26 to +45

@coderabbitai coderabbitai Bot Oct 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using boolean type for flag parameters.

The skip-tests and is-pg-build parameters are boolean flags but defined as string type with "false" default. Using the native boolean type would be more appropriate and consistent with GitHub Actions best practices.

   workflow_dispatch:
     inputs:
       pr:
         description: "PR number for the workflow"
         required: false
         type: number
       skip-tests:
         description: "Skip tests flag"
         required: false
-        type: string
-        default: "false"
+        type: boolean
+        default: false
       branch:
         description: "Branch for the build"
         required: false
         type: string
       is-pg-build:
         description: "Flag for PG build"
         required: false
-        type: string
-        default: "false"
+        type: boolean
+        default: false
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
workflow_dispatch:
inputs:
pr:
description: "PR number for the workflow"
required: false
type: number
skip-tests:
description: "Skip tests flag"
required: false
type: string
default: "false"
branch:
description: "Branch for the build"
required: false
type: string
is-pg-build:
description: "Flag for PG build"
required: false
type: string
default: "false"
workflow_dispatch:
inputs:
pr:
description: "PR number for the workflow"
required: false
type: number
skip-tests:
description: "Skip tests flag"
required: false
type: boolean
default: false
branch:
description: "Branch for the build"
required: false
type: string
is-pg-build:
description: "Flag for PG build"
required: false
type: boolean
default: false


# Change the working directory for all the jobs in this workflow
defaults:
run:
Expand Down