Skip to content

test: fix tabs skipped test CE #37023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NandanAnantharamu merged 4 commits into from
Oct 25, 2024
+13 −6
Merged

test: fix tabs skipped test CE #37023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b2effc
test: fix tabs skipped test CE
Oct 23, 2024
976e4fd
Merge branch 'release' into test/fixTabsCE
Oct 24, 2024
ac79d18
updated test steps
Oct 24, 2024
6b0e607
reverted limited run file
Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions app/client/cypress/e2e/Regression/ClientSide/Widgets/Tab/Tabs_2_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ describe(
});

// to work on redesign of the test, commenting for now
it.skip("7. Verify colors, borders and shadows", () => {
it("7. Verify colors, borders and shadows", () => {
// Verify font color picker opens up
propPane.MoveToTab("Style");
agHelper.GetNClick(propPane._propertyControlColorPicker("accentcolor"));
Expand Down Expand Up @@ -220,11 +220,16 @@ describe(
// Border Color
propPane.SelectColorFromColorPicker("bordercolor", 13);
assertHelper.AssertNetworkStatus("@updateLayout");
agHelper.AssertCSS(
tabs._tabsWidgetStyle,
"border-color",
"rgb(185, 28, 28)",
);

agHelper
.GetWidgetCSSFrAttribute(propPane._borderColorCursor, "color")
.then((color) => {
agHelper
.GetWidgetCSSFrAttribute(locators._widgetBorder, "color", 1)
.then((bgcolor) => {
expect(color).to.eq(bgcolor);
});
});

agHelper.AssertAttribute(propPane._colorPickerInput, "type", "text", 2);
propPane.TogglePropertyState("bordercolor", "On", "");
Expand Down
1 change: 1 addition & 0 deletions app/client/cypress/support/Objects/CommonLocators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,4 +341,5 @@ export class CommonLocators {
_saveDatasource = `[data-testid='t--store-as-datasource']`;
_propertyCollapseBody = ".bp3-collapse-body";
_propertyCollapse = ".bp3-collapse";
_widgetBorder = ".t--draggable-tabswidget div div div";
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Use data- attribute selector instead of CSS path*

The current selector .t--draggable-tabswidget div div div is fragile and depends on DOM structure. Consider:

  1. Using a data-* attribute for better resilience
  2. Making the property name more specific to tabs widget

Apply this diff:

-  _widgetBorder = ".t--draggable-tabswidget div div div";
+  _tabsWidgetBorder = "[data-testid='t--tabs-widget-border']";

Then add the corresponding data-testid attribute to the tabs widget border element.

Committable suggestion was skipped due to low confidence.

}
1 change: 1 addition & 0 deletions app/client/cypress/support/Pages/PropertyPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ export class PropertyPane {
_dataIcon = (icon: string) => `[data-icon="${icon}"]`;
_iconDropdown = "[data-test-id='virtuoso-scroller']";
_dropdownControlError = "[data-testid='t---dropdown-control-error']";
_borderColorCursor = ".t--property-control-bordercolor .bp3-input-group div";

public OpenJsonFormFieldSettings(fieldName: string) {
this.agHelper.GetNClick(this._jsonFieldEdit(fieldName));
Expand Down