Skip to content

DNM: In progress : Fixed chrome version #36972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagar-qa007 wants to merge 2 commits into from
Closed

DNM: In progress : Fixed chrome version #36972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc8259a
Fixing chrom version
sagar-qa007 Oct 18, 2024
50611d6
updated anvil
sagar-qa007 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-custom-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 129
- run: |
Comment on lines 259 to 261
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using a more flexible Chrome version specification.

Explicitly setting Chrome version to 129 might lead to version conflicts in the future. Consider using a more flexible version specification or regularly updating this value to match the latest stable version.

🧰 Tools
🪛 actionlint

261-261: shellcheck reported issue in this script: SC2086:info:1:40: Double quote to prevent globbing and word splitting

(shellcheck)

echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-hosted.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 129
- run: |
echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-limited-with-count.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 129
- run: |
echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-limited.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ jobs:

- uses: browser-actions/setup-chrome@latest
with:
chrome-version: stable
chrome-version: 129
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update Chrome version to latest stable

The specified Chrome version (129) is outdated. Update to the latest stable version (130) or use "stable" for automatic updates.

chrome-version: stable

This change ensures compatibility with the current test suite and reduces manual version updates.

🔗 Analysis chain

Verify Chrome version compatibility

The Chrome version has been updated from 'stable' to a specific version '129'. Ensure this version is compatible with our current test suite and CI environment.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if Chrome 129 is the latest stable version
latest_stable=$(curl -s https://omahaproxy.appspot.com/all.json | jq -r '.[] | select(.os=="linux") | .versions[] | select(.channel=="stable") | .version' | head -n1)
if [[ "$latest_stable" == "129."* ]]; then
  echo "Chrome 129 is the latest stable version."
else
  echo "Warning: Chrome 129 is not the latest stable version. Latest stable is $latest_stable"
fi

Length of output: 405

Script:

#!/bin/bash
# Fetch and display the JSON structure from Omaha Proxy
curl -s https://omahaproxy.appspot.com/all.json | jq .

Length of output: 113

Script:

#!/bin/bash
# Fetch and display the raw JSON structure from Omaha Proxy
curl -s https://omahaproxy.appspot.com/all.json

Length of output: 173

Script:

#!/bin/bash
# Fetch and display the latest stable Chrome version from Chromium Dash
latest_stable=$(curl -s https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Linux | jq -r '.[0].version')
if [[ "$latest_stable" == "129."* ]]; then
  echo "Chrome 129 is the latest stable version."
else
  echo "Warning: Chrome 129 is not the latest stable version. Latest stable is $latest_stable"
fi

Length of output: 217191

- run: |
echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV

Expand Down
10 changes: 3 additions & 7 deletions app/client/cypress/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
#ARG CHROME_VERSION="126.0.6478.114-1"
ARG CHROME_VERSION="129.0.6668.100-1"
ARG YARN_VERSION='1.22.22'
ARG NODE_VERSION='20.13.1'
ARG CYPRESS_VERSION='13.13.0'
FROM cypress/factory:4.0.2
FROM --platform=linux/amd64 cypress/factory:4.0.2
Copy link
Collaborator

@KelvinOm KelvinOm Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried this configuration, but it doesn't work that way. The docker process starts taking up the entire CPU resource and the tests just hang. I tried it on two different machines(M2 and M3).
Снимок экрана 2024-10-23 в 12 19 32

Copy link
Contributor Author

@sagar-qa007 sagar-qa007 Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KelvinOm Yes there is open bug for it apart from this CPU usage. I will spend sometime later once this become priority. cypress-io/cypress#29095

Copy link
Collaborator

@KelvinOm KelvinOm Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar-qa007 The issue is that we cannot consider this as a solution. Because we just won't be able to use it. How do you run this locally?You work on a mac like the rest of us, right?

Copy link
Contributor Author

@sagar-qa007 sagar-qa007 Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am reiterating this, kindly wait for the fix. I am marking this PR as do not merge as it is in progress.

Copy link
Collaborator

@KelvinOm KelvinOm Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it turns out, the fix of this situation can be waited for a very long time. Can we consider using chromium instead of chrome for testing?

@sagar-qa007 @yatinappsmith


# Install chromium in this way since there is no browsers in the docker container for the arm64 architecture
# https://github.com/cypress-io/cypress-docker-images/issues/695
RUN apt update && apt install -y chromium

ENTRYPOINT ["yarn", "cypress:snapshot"]
ENTRYPOINT [ "yarn", "cypress:snapshot"]
6 changes: 3 additions & 3 deletions app/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
"check-types": "yarn tsc --noEmit",
"init-husky": "cd ../.. && husky install app/client/.husky",
"clean:workspaces": "yarn workspaces foreach -pAv exec rm -rf node_modules",
"cypress:snapshot": "npx cypress run -b chromium -s",
"cypress:snapshot:docker": "docker run --network='host' -it --rm -e CYPRESS_$1 -v $PWD:/cypress -w /cypress cypress-snapshot $0",
"cypress:snapshot:docker:build": "docker build . -f cypress/Dockerfile -t cypress-snapshot"
"cypress:snapshot": "npx cypress run -b chrome -s",
"cypress:snapshot:docker": "DEBUG=cypress:* docker run --platform linux/amd64 --network='host' -it --rm -e CYPRESS_UPDATE_SNAPSHOTS=$1 -v $PWD:/cypress -w /cypress cypress-snapshot $0",
Copy link
Collaborator

@KelvinOm KelvinOm Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't run this script because of error No matches found: "cypress:*".

Copy link
Contributor Author

@sagar-qa007 sagar-qa007 Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check this.

"cypress:snapshot:docker:build": "docker build --platform linux/amd64 . -f cypress/Dockerfile -t cypress-snapshot"
},
"dependencies": {
"@appsmith/ads": "workspace:^",
Expand Down