Skip to content

chore: fix markdown styles #36959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KelvinOm merged 1 commit into from
Oct 18, 2024
Merged

chore: fix markdown styles #36959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/client/packages/design-system/widgets/src/components/Markdown/src/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import type { Components } from "react-markdown";

import { a } from "./mdComponents/Link";
import { code } from "./mdComponents/Code";
import { p } from "./mdComponents/Paragraph";
import { ul, ol, li } from "./mdComponents/List";
import { h1, h2, h3, h4, h5, h6 } from "./mdComponents/Heading";

export const components: Components = {
Expand All @@ -14,9 +12,5 @@ export const components: Components = {
h4,
h5,
h6,
p,
ul,
ol,
li,
code,
};
28 changes: 0 additions & 28 deletions app/client/packages/design-system/widgets/src/components/Markdown/src/mdComponents/List.tsx
View file
Open in desktop
Copy link
Contributor Author

@jsartisan jsartisan Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i realized these wrappers are not needed anymore as I removed the text wrapper.

This file was deleted.

22 changes: 0 additions & 22 deletions ...ent/packages/design-system/widgets/src/components/Markdown/src/mdComponents/Paragraph.tsx
View file
Open in desktop
Copy link
Contributor Author

@jsartisan jsartisan Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using our Text component as the capsizing is causing issues with list item markers. Anyway, we used capsizing for single line use cases ( like text in button ). Having capsizing for everything is causing more harm than good.

This file was deleted.

13 changes: 5 additions & 8 deletions app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,26 +74,23 @@
margin-bottom: var(--inner-spacing-1);
}

[data-component="p"] {
margin-bottom: var(--inner-spacing-3);
}

/* Lists */
:is(ul, ol) {
margin-top: var(--inner-spacing-2);
margin-bottom: var(--inner-spacing-4);
margin-bottom: var(--inner-spacing-3);
padding-left: 0;
list-style: initial;
}

li {
margin-bottom: var(--inner-spacing-2);
margin-left: 1em;
position: relative;
list-style-type: auto;
}

[data-component="a"]:before,
[data-component="a"]:after {
content: none;
a {
display: inline-block;
}

[data-component="code"] {
Expand Down